Skip to content

ci: restore required test status context - #121

Merged
timeleft-- merged 1 commit into
mainfrom
fix/required-test-context
Sep 19, 2026
Merged

timeleft-- merged 1 commit into
mainfrom
fix/required-test-context

Conversation

@timeleft--

Copy link
Copy Markdown
Member

Branch protection requires a test status, while the matrix job now emits only test (0.28.0) and test (0.45.1). Clean pull requests therefore remain blocked after both matrix jobs and review pass.

Add a small aggregate test job that succeeds only when the full JJ matrix succeeds. This restores the existing protected-branch contract without weakening or changing repository protection settings.

Validation: git diff --check; workflow structure reviewed locally. GitHub Actions provides final matrix and aggregate validation on this pull request.

@timeleft--

Copy link
Copy Markdown
Member Author

Hermes review findings were written locally at /Users/yianaga/Documents/AgenticWork/active/investigations/wisdom-finish-20260907/fava-required-test/.wise-agents/reviews/hermes/20260919T221505Z-fix-required-test-context-findings.md.

API call failed after 3 retries: Codex stream produced no SSE events for 12s after the first parsed event (threshold: 12s)

@yia-mw-agent yia-mw-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent exact-head acceptance of 362e44b: the aggregate job is named exactly test, waits for the full JJ matrix, runs even after failure/cancellation, and exits successfully only when the matrix result is success. Both matrix runs and both aggregate test contexts passed, along with semantic PR and CodeQL checks. This restores the existing protected-branch contract without weakening branch protection.

@timeleft--
timeleft-- merged commit 8181b84 into main Sep 19, 2026
11 checks passed
@timeleft--
timeleft-- deleted the fix/required-test-context branch September 19, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants