Conversation
khassel
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the Finnish Meteorological Institute (FMI) as a weather provider for the default weather module.
The provider uses FMI Open Data services and does not require an API key.
It supports:
The implementation uses latitude and longitude coordinates, consistent with the existing weather provider configuration.
Related issue
No related issue.
Additional changes
Testing
Tested locally on Windows 11.
FMI provider tests:
17 passed (17)Full unit test suite:
489 passed, 1 failed (490 total)The single failing test is
tests/unit/classes/systeminformation_spec.js, which expectsplatform: linux. The local test environment reportsplatform: Windows. The FMI provider tests pass successfully.npm run config:checkalso passes successfully.The provider was additionally tested with live FMI data in MagicMirror using current, forecast, and hourly weather module instances.