-
Notifications
You must be signed in to change notification settings - Fork 1
fix(stats): count coverage against all 15 libraries #11835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+225
−56
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| ### Fixed | ||
|
|
||
| - **Coverage matrix on the stats page counted against 9 libraries instead of | ||
| 15.** Every cell tooltip read `15/9` for a fully covered spec, and the | ||
| "possible implementations" total was short by the same factor, because the | ||
| page carried a hardcoded library count from back when nine were supported. | ||
| `/insights/dashboard` now serves `total_libraries` (the canonical | ||
| `SUPPORTED_LIBRARIES` size that already backs `coverage_percent`) and the page | ||
| renders against it, so the denominator follows the library set instead of | ||
| drifting from it. | ||
|
|
||
| ### Changed | ||
|
|
||
| - **Coverage cells read as three states, not a gradient.** The mark grew from | ||
| 10 px to 16 px inside a 24 px hit area (WCAG 2.2 SC 2.5.8), and full coverage | ||
| now renders as solid brand green while anything short of it carries an ink | ||
| outline (dashed when a spec has no implementation at all), with a labelled | ||
| legend replacing the less/more ramp. | ||
| The interesting signal is which specs are *not* complete, and those are the | ||
| minority — the old opacity ramp made them the hardest cells to pick out. The | ||
| summary line also names how many specs are below full coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.