Skip to content

fix: mark frontend UI peer dependencies as optional for DSH Desktop - #52

Merged
Mars-Sea merged 1 commit into
Mars-Sea:mainfrom
zhangxaochen:fix/desktop-optional-ui-peers
Sep 18, 2026
Merged

Mars-Sea merged 1 commit into
Mars-Sea:mainfrom
zhangxaochen:fix/desktop-optional-ui-peers

Conversation

@zhangxaochen

Copy link
Copy Markdown
Contributor

Summary

When running inside DeepSeek Harness Desktop (the Electron app), the Desktop runtime strictly validates plugin peer dependencies at the Node host layer (\�pps/desktop/src/profile-packages.ts).

Since @deepseek-ai/dsh-client-ui-primitives, @deepseek-ai/dsh-client-ui-slots, and
eact\ are client-only modules bundled directly into DSH's frontend webview bundle, they are not provided as standalone Node modules by the Desktop host. Without \peerDependenciesMeta: { optional: true }, Desktop startup fails with:

\`ndesktop profile: @mars-sea/dsh-commandcode-provider requires missing @deepseek-ai/dsh-client-ui-primitives@...
\`n

Changes

Added \peerDependenciesMeta\ in \package.json\ declaring:

  • @deepseek-ai/dsh-client-ui-primitives\ as optional
  • @deepseek-ai/dsh-client-ui-slots\ as optional

  • eact\ as optional

This follows DSH's peer dependency verification contract and allows the plugin to boot smoothly in Desktop without affecting Web or TUI profiles.

@Mars-Sea
Mars-Sea merged commit e2e8bb0 into Mars-Sea:main Sep 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants