Conversation
mgree
force-pushed
the
trycast
branch
5 times, most recently
from
September 15, 2026 15:48
4b88aa2 to
a1477a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes https://linear.app/materializeinc/issue/CS-334/safe-cast-try-cast-function-for-handling-bad-data-on-ingest.
Description
A
TRY_CAST(<expr> AS <type>)evaluates<expr>once and attempts to cast it to<type>. While casts can fail (e.g., not every string is an integer!),TRY_CASTwill detect failures and produceNULLinstead.Verification
Extensive testing for each cast: good values stay good, bad values turn into NULL. This testing is in SLTs, proptests, and concrete unit tests with chosen values.