Fix uninitialized loop counter in intialize_hypothesis_rulesets - #433
Open
drbergman wants to merge 1 commit into
Open
Fix uninitialized loop counter in intialize_hypothesis_rulesets#433drbergman wants to merge 1 commit into
drbergman wants to merge 1 commit into
Conversation
The loop over cell_definitions_by_index declared `int n` without an initializer, so the loop started from an indeterminate value. Depending on the garbage value, this could skip creating hypothesis rulesets for some or all cell definitions, or index out of range. Every sibling loop in this file already uses `int n=0`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
drbergman
marked this pull request as ready for review
August 19, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
intialize_hypothesis_rulesets(core/PhysiCell_rules.cpp), the loop counter is declared without an initializer:this fixes that