Compare neighbor type against diff_type in the interactions sample - #434
Open
drbergman wants to merge 1 commit into
Open
Compare neighbor type against diff_type in the interactions sample#434drbergman wants to merge 1 commit into
drbergman wants to merge 1 commit into
Conversation
In stem_cell_phenotype() the neighbor-counting loop tested `pC->type == num_differentiated`, comparing the neighbor's type against the running num_differentiated counter instead of against diff_type. Because num_differentiated starts at 0, the test walked up the cell definition list as it incremented: with this sample's definitions (bacteria=0, blood vessel=1, stem=2, differentiated=3) it first counted bacteria neighbors, then blood vessel, then stem, and only then differentiated. num_differentiated feeds the stem cycling exit rate, so stem proliferation was driven by the wrong contact count. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An obvious typo in the interactions sample project. Fixing this likely changes simulation output and so we would need to fix the test artifacts.