feat: resolve swap quote metadata by migration phase - #9744
Open
micaelae wants to merge 85 commits into
Open
Conversation
This reverts commit aa5c5d2.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
micaelae
force-pushed
the
swaps4547-use-v2-migration
branch
from
August 7, 2026 01:11
363f891 to
8257447
Compare
micaelae
enabled auto-merge
August 7, 2026 01:15
micaelae
force-pushed
the
swaps4547-use-v2-migration
branch
from
August 7, 2026 01:33
cb46f5f to
3885f72
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3885f72. Configure here.
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Draft client PRs
References
Checklist
Note
High Risk
Breaking selector and submit APIs change how bridge/swap quotes expose fees, fiat, and legacy fields—incorrect
migrationPhasecan mislead users at confirmation and in metrics until clients adopt the extension/mobile PRs.Overview
Introduces a breaking
migrationPhaseoption on bridge quote selectors and onbridge-status-controllersubmit paths (submitTx,submitIntent,submitBatchSell). Clients must passQuoteMetadataMigrationPhaseto control how quote amounts and fiat values are built during the V1 → V2 metadata migration.Phase behavior: Phase 1 (
V1Data) keeps client-facing legacy fields fromcalcQuoteMetadataand skips V2 fiat derivation. Phase 1.5 (V2WithV1Fallback) prefers nested V2/API metadata plus fiat from USD, with legacy fallback. Phase 2 (V2Only) drops legacy metadata entirely and merges only normalized V2 fields andtoCurrencyValuesoutput.mergeQuoteMetadatais now V2-only and takesmigrationPhaseplus optional currency partials; V1 quote merging was removed.toQuoteMetadataV1is phase-aware so submission can still produce V1-shaped metadata from V2 quotes. Selectors gainselectUsdToFiatExchangeRate,selectCurrencyValues, and updated merge ordering per phase.QuoteMetadataMigrationPhaseis exported frombridge-controller.Reviewed by Cursor Bugbot for commit 4c8a5df. Bugbot is set up for automated code reviews on this repo. Configure here.