feat(profile-sync-controller): use KeyringController to resolve entropySourceIds instead of @metamask/message-signing-snap - #9794
Open
mathieuartu wants to merge 5 commits into
Open
Conversation
…py source IDs instead of message-signing-snap
mathieuartu
temporarily deployed
to
default-branch
August 5, 2026 13:05 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 99fd724. Configure here.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
mathieuartu
changed the title
KeyringController to resolve entropySourceIds instead of @metamask/message-signing-snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
From CHANGELOG:
References
Related to: https://consensyssoftware.atlassian.net/browse/MUL-2057
Extension test-drive PR: MetaMask/metamask-extension#45250
Checklist
Note
Medium Risk
Changes how primary and multi-SRP IDs are resolved in the sign-in and token paths; incorrect keyring ordering or empty keyrings could mis-tag logins or fail auth, though behavior is intended to mirror the prior snap enumeration.
Overview
Authentication and user storage now derive HD entropy source IDs from
KeyringControllerkeyring metadata instead of the message-signing snap’sgetAllPublicKeys, so paths likegetBearerToken()andperformSignInSRP enumeration are not blocked on snap boot.Shared helpers in
shared/utils/entropy-source.ts(getHdKeyringEntropySourceIds,getPrimaryHdKeyringEntropySourceId) centralize that logic;UserStorageControlleradopts them in place of inline filtering.AuthenticationControllerdrops snapgetAllPublicKeys, the cached primary-ID field, and thecreateSnapAllPublicKeysRequesthelper—snap remains forgetPublicKey/signMessageduring login. Primary/canonical resolution is now synchronous off keyring state; missing HD keyrings throwno HD keyring availableinstead of snap-specific errors.Reviewed by Cursor Bugbot for commit 98d77bc. Bugbot is set up for automated code reviews on this repo. Configure here.