Require manual confirmation after OreSpawn release tags - #246
Merged
Conversation
SkyBlade1978
merged commit Aug 24, 2026
515046f
into
MinecraftModDevelopmentMods:master-1.10.2
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mode=publishautomaticallyAfter creating a valid release tag, the operator must now deliberately run the dispatcher and provide:
publishrelease,beta, oralphaThe dispatcher then builds and audits the immutable bundle before stopping at the separate
releaseenvironment approval gate. Maven, CurseForge, and GitHub publication cannot begin until that approval is granted.Why
The original starter hard-coded
publish,release, and the confirmation value immediately after a tag push. That removed the intended opportunity to inspect the tagged candidate, select the CurseForge release level, and explicitly confirm live publication.Validation
actionlint1.7.12 passes all workflow filesgit diff --checkpassesgh workflow run,mode=publish, oractions: writepathmode,release_ref,curseforge_channel, andconfirm_version, and retains thereleaseenvironment gatePublication boundary
Merging this PR does not create a tag, start the dispatcher, or publish any release.