Skip to content

Retry transient Forge cold-bootstrap downloads #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkyBlade1978 merged 1 commit into from
Sep 1, 2026
Merged

Retry transient Forge cold-bootstrap downloads #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,31 @@ jobs:
set -euo pipefail
test ! -e .gradle
test ! -e "$GRADLE_USER_HOME"
mkdir -p "$GRADLE_USER_HOME"
chmod +x ./gradlew
./gradlew verifyMavenizerCompatibilityFixture help \
--no-daemon --no-build-cache --stacktrace --max-workers=2 \
-Dorg.gradle.java.installations.paths="$JAVA_HOME,$JAVA_HOME_8_X64,$JAVA_HOME_25_X64" \
-Dorg.gradle.java.installations.auto-detect=false \
-Dorg.gradle.java.installations.auto-download=false \
| tee "$RUNNER_TEMP/cold-forge-bootstrap.log"
gradle_args=(
verifyMavenizerCompatibilityFixture help
--no-daemon --no-build-cache --stacktrace --max-workers=2
"-Dorg.gradle.java.installations.paths=$JAVA_HOME,$JAVA_HOME_8_X64,$JAVA_HOME_25_X64"
-Dorg.gradle.java.installations.auto-detect=false
-Dorg.gradle.java.installations.auto-download=false
)
for attempt in 1 2 3; do
if (( attempt > 1 )); then
echo "Retrying the cold Forge bootstrap after transient download failure ($attempt/3)"
rm -rf -- "$GRADLE_USER_HOME/caches/minecraftforge" .gradle/mavenizer
sleep "$((attempt * 5))"
fi
mkdir -p "$GRADLE_USER_HOME"
attempt_log="$RUNNER_TEMP/cold-forge-bootstrap-attempt-$attempt.log"
if ./gradlew "${gradle_args[@]}" 2>&1 | tee "$attempt_log"; then
cp "$attempt_log" "$RUNNER_TEMP/cold-forge-bootstrap.log"
break
fi
if (( attempt == 3 )); then
echo "Cold Forge bootstrap failed after $attempt attempts" >&2
exit 1
fi
done
grep -F "OreSpawn Mavenizer compatibility runtime: Java 25.0.3" \
"$RUNNER_TEMP/cold-forge-bootstrap.log"
grep -F "OreSpawn Mavenizer compatibility: applied 0 rule(s) for net.minecraftforge:forge:1.21.1-52.1.0 (explicit no-op)" \
Expand Down
14 changes: 14 additions & 0 deletions src/test/java/zone/moddev/mc/orespawn/ReleaseWorkflowContractTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,20 @@ void codeQlUsesABoundedCachePreservingCompileRetry() throws Exception {
"CodeQL must fail rather than hide a persistent bootstrap defect");
}

@Test
void coldForgeBootstrapRetriesTransientDownloadsWithoutAcceptingPersistentFailure() throws Exception {
String text = new String(Files.readAllBytes(
Paths.get(".github", "workflows", "ci.yml")), StandardCharsets.UTF_8);
assertTrue(text.contains("for attempt in 1 2 3; do"),
"Cold Forge bootstrap must bound transient download retries");
assertTrue(text.contains("./gradlew \"${gradle_args[@]}\" 2>&1 | tee \"$attempt_log\""),
"Every retry must preserve the exact Gradle bootstrap arguments and diagnostics");
assertTrue(text.contains("rm -rf -- \"$GRADLE_USER_HOME/caches/minecraftforge\" .gradle/mavenizer"),
"Retries must discard partial Forge and Mavenizer state");
assertTrue(text.contains("Cold Forge bootstrap failed after $attempt attempts"),
"A persistent bootstrap failure must still fail CI");
}

private static int occurrences(String text, String needle) {
int count = 0;
int offset = 0;
Expand Down
Loading