Poll asynchronous jobs before downloading example outputs - #38
Open
Ray0907 wants to merge 1 commit into
Open
Conversation
Ray0907
marked this pull request as ready for review
August 11, 2026 06:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The video endpoints return an asynchronous job ID. The examples previously
queried each job only once and then attempted to read or download its output,
which fails whenever the job is still queued or processing.
The defaults poll every 10 seconds for up to two hours. Users can override
POLL_INTERVAL_SECONDS,POLL_TIMEOUT_SECONDS, and theHTTP_*retry valuesfor their deployment.
Validation
bash -npassed for all 19 scripts inscripts/readmegit diff --checkThe SGLang status handling follows its documented asynchronous video flow:
https://docs.sglang.io/cookbook/diffusion/MiniMax/MiniMax-H3#4-generate-video-and-audio
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.