fix: time out stalled streams - #227
Merged
Merged
Conversation
victor0602
marked this pull request as ready for review
August 5, 2026 12:11
NianJiuZst
reviewed
Aug 10, 2026
NianJiuZst
left a comment
Collaborator
There was a problem hiding this comment.
No blocking findings on the current head. The header timeout, resettable body-idle timeout, and consumer-cancellation propagation are internally consistent, and I recommend merging this PR on its present base.
Verified locally: typecheck, lint (one pre-existing warning), build, 22 focused HTTP/stream tests, and the full suite (453/453). This is source/mock proof; I did not run a live long-lived provider stream. If another src/client/http.ts PR lands first, this should be rebased and the combined behavior re-tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Streaming requests previously removed the timeout signal entirely and could hang forever when a server stopped sending data.
Impact
Stalled streams now fail predictably and release their resources, while healthy long-running streams continue normally.
Checks
bun test— 453 passedbun run typecheckbun run lint— no errors; one pre-existing test warninggit diff --checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.