Skip to content

JIT works only partially with meson build? - #417

Open
pg-hub-mirror[bot] wants to merge 1 commit into
masterfrom
pg-hub/mirror-patch-d2c3bc85ae816a7e
Open

pg-hub-mirror[bot] wants to merge 1 commit into
masterfrom
pg-hub/mirror-patch-d2c3bc85ae816a7e

Conversation

@pg-hub-mirror

@pg-hub-mirror pg-hub-mirror Bot commented Sep 18, 2026

Copy link
Copy Markdown

Read-only mirror. Reply and review on pgsql-hackers; activity here is not sent upstream.

  • Original author: shihao zhong <zhong950419(at)gmail(dot)com>
  • Mailing list: pgsql-hackers
  • Message-ID: CAGRkXqQd26aCrGX03fXiV9MWZmAtYsFDd9N5HzHOxsiSfoKsXA@mail.gmail.com
  • Original email

Patch files:


Hi Yugo,
cfbot fails because v2 is a plain diff, and git am cannot apply it.
Attached v3 is the same change made with git format-patch, plus a
commit message. It applies to master and REL_16_STABLE through
REL_19_STABLE.
One suggestion: EXPLAIN still shows "Inlining: true" in this case,
since it only checks PGJIT_INLINE. Maybe the note should say so.
Regards,
Shihao

@pg-hub-mirror pg-hub-mirror Bot added source:pgsql-hackers Mirrored from pgsql-hackers type:patch Mail thread contains a PostgreSQL patch labels Sep 18, 2026
@pg-hub-mirror pg-hub-mirror Bot locked and limited conversation to collaborators Sep 18, 2026
@pg-hub-mirror pg-hub-mirror Bot added cf:pg20-2 PostgreSQL CommitFest area:docs Documentation status:ready-for-committer CommitFest: Ready for Committer labels Sep 18, 2026
@pg-hub-mirror pg-hub-mirror Bot added this to the PG20-2 milestone Sep 18, 2026
Meson builds do not generate the LLVM bitcode that JIT inlining
needs.  So with -Dllvm, JIT compilation works, but inlining does
not.  Document that in the JIT chapter, and mention -Dllvm next to
--with-llvm.

While at it, use <option> for --with-llvm, per review.

This should be reverted once Meson learns to build the bitcode.

Author: Yugo Nagata <nagata@sraoss.co.jp>
Reviewed-by: Laurenz Albe <laurenz.albe@cybertec.at>
Reviewed-by: shihao zhong <zhong950419@gmail.com>
Discussion: https://postgr.es/m/20250526150820.28ea70625645e0d6d12be7d5@sraoss.co.jp
Backpatch-through: 16
@pg-hub-mirror
pg-hub-mirror Bot force-pushed the pg-hub/mirror-patch-d2c3bc85ae816a7e branch from 81f2bc7 to 2038cd5 Compare September 18, 2026 14:30
@pg-hub-mirror

pg-hub-mirror Bot commented Sep 18, 2026

Copy link
Copy Markdown
Author

Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> via pgsql-hackers · original email

Hi Shihao,
On Thu, 17 Sep 2026 22:13:02 -0400
shihao zhong <zhong950419(at)gmail(dot)com> wrote:

Hi Yugo,

cfbot fails because v2 is a plain diff, and git am cannot apply it.
Attached v3 is the same change made with git format-patch, plus a
commit message. It applies to master and REL_16_STABLE through
REL_19_STABLE.

One suggestion: EXPLAIN still shows "Inlining: true" in this case,
since it only checks PGJIT_INLINE. Maybe the note should say so.
Thak you for updating the patch.
I've attached an updated path incorporating your suggestion.
Regards,]
Yugo Nagata
--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

New patch set: v4-0001-doc-Mention-that-JIT-inlining-does-not-work-with-.patch

@pg-hub-mirror pg-hub-mirror Bot unlocked this conversation Sep 18, 2026
@pg-hub-mirror pg-hub-mirror Bot locked and limited conversation to collaborators Sep 18, 2026
@pg-hub-mirror pg-hub-mirror Bot unlocked this conversation Sep 18, 2026
@pg-hub-mirror

pg-hub-mirror Bot commented Sep 18, 2026

Copy link
Copy Markdown
Author

Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> via pgsql-hackers · original email

On Fri, 18 Sep 2026 21:00:20 +0900
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:

Hi Shihao,

On Thu, 17 Sep 2026 22:13:02 -0400
shihao zhong <zhong950419(at)gmail(dot)com> wrote:

Hi Yugo,

cfbot fails because v2 is a plain diff, and git am cannot apply it.
Attached v3 is the same change made with git format-patch, plus a
commit message. It applies to master and REL_16_STABLE through
REL_19_STABLE.

One suggestion: EXPLAIN still shows "Inlining: true" in this case,
since it only checks PGJIT_INLINE. Maybe the note should say so.

Thak you for updating the patch.
I've attached an updated path incorporating your suggestion.
It may be unnecessary once the LLVM bitcode emission patches [1] are
committed, though.
[1] https://www.postgresql.org/message-id/flat/CAN55FZ26ohMftt20NUtVAxU8Feqjhz-jEfUvFKATYEaRR%2Bxmqg%40mail.gmail.com#a7b90ab42f2c38fcddca74f063741c9d
Regards,
Yugo Nagata
--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

@pg-hub-mirror pg-hub-mirror Bot locked and limited conversation to collaborators Sep 18, 2026
@pg-hub-mirror pg-hub-mirror Bot added the area:sql SQL language or commands label Sep 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area:docs Documentation area:sql SQL language or commands cf:pg20-2 PostgreSQL CommitFest source:pgsql-hackers Mirrored from pgsql-hackers status:ready-for-committer CommitFest: Ready for Committer type:patch Mail thread contains a PostgreSQL patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant