fix: clear nightly CI audit failure (nanoid 3.3.18) and group Dependabot updates — 3.1.1 - #229
Closed
VibhavSetlur wants to merge 4 commits into
Closed
fix: clear nightly CI audit failure (nanoid 3.3.18) and group Dependabot updates — 3.1.1#229VibhavSetlur wants to merge 4 commits into
VibhavSetlur wants to merge 4 commits into
Conversation
Collaborator
Author
|
Superseded by #230 — same change, byte-identical diff, but on a dedicated head branch ( Reason: this PR's head was my Please review and merge #230 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The nightly scheduled CI run (
.github/workflows/ci.yml, cron0 6 * * *) has failedevery night. The only failing step is step 9,
Audit production dependencies (high/critical) —
npm audit --omit=dev --audit-level=high. Lint, type-check, unit tests and buildall pass. The same scheduled run fails on
ModelSEED/ModelSEED-UIitself, so this isnot fork drift — the fork's
masterandstagingare byte-identical to upstream.On
stagingthe audit reported exactly one high advisory:nanoid3.3.17 — GHSA-2v37-7h3g-55p8.nanoidis a production transitive ofpostcss(range^3.3.16), so 3.3.18 satisfies it as a lockfile-only change.What changed
fix(deps)—package-lock.json:nanoid3.3.17 → 3.3.18, closingGHSA-2v37-7h3g-55p8. No
package.jsondependency ranges were touched.chore(deps)—.github/dependabot.yml: routine npm version updates are nowgrouped into one production and one development PR, weekly, limit 5
(previously: daily, ungrouped, limit 10 — which is what produces the flood of
one-PR-per-package). Dependabot security updates are generated independently
of version-update groups and are not suppressed by grouping; they continue to
open individually and promptly.
fix(release)— 3.1.0 → 3.1.1 acrossVERSION.md,package.jsonand thepackage-lock.jsonroot version fields, plus a dated[3.1.1]CHANGELOG.mdsection, per
CONTRIBUTING.md(fix-only commit set → patch bump).What deliberately did not change
.github/workflows/ci.ymlis untouched — the high/critical audit gate and thenightly schedule both stay exactly as they are. Nothing was muted or weakened.
Verification (conda env
modelseed-ui, mirrors CI)npm cinpm audit --omit=dev --audit-level=highfound 0 vulnerabilities({info:0, low:0, moderate:0, high:0, critical:0})npm run lintnpx tsc --noEmitnpm run test:runnpm run buildNote for
mastermaster(v3.0.0,e61279c) still carries four high advisories —next16.2.6,postcss8.5.12,sharp0.34.5 andnanoid3.3.11 — which is why the nightly runon
masteris red.stagingalready carriesnext16.3.0 /postcss8.5.25 /sharp0.35.3, so once this lands andstagingis merged tomaster, all fourclear. This PR intentionally does not edit dependencies on
master.