feat(hooks): allow hooks to answer tool approvals - #2943
Open
rullerzhou-afk wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: c4dbb52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1326
Problem
PermissionRequesthooks can observe a native tool approval but cannot answer it.PreToolUsecan deny a call, but an allow result only means that the hook does not object, so manual mode still opens the native approval UI. External approval surfaces therefore cannot approve a request without creating a second prompt.What changed
PermissionDecisionRequesthook for ordinary tool approvals in both agent-core implementations.permission_request_id; decisions are per request and are not persisted as reusable rules.UI compatibility
A hook decision is resolved before the existing session approval broker is called. It therefore does not create a pending interaction for the TUI, Kimi Web, or Kimi Code for VS Code to render. When hooks produce no valid decision, the unchanged broker path creates the normal native approval request.
Verification
@moonshot-ai/agent-coretests passed.@moonshot-ai/agent-core-v2tests passed.Bashrequest was hook-approved without opening the native panel.Bashrequest was hook-approved without a web approval dialog or stale pending state.oxlint --type-awarecompleted with 0 errors.git diff --checkpassed.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update. The currentmainbranch does not contain the skill's requireddocs/scripts/sync-changelog.mjs; the mirrored English/Chinese hook docs were reviewed directly and the VitePress build passes.