Skip to content

[FEATURE] Add support for PHP 8.6 - #1619

Merged
JakeQZ merged 1 commit into
mainfrom
feature/php-86
Aug 29, 2026
Merged

[FEATURE] Add support for PHP 8.6#1619
JakeQZ merged 1 commit into
mainfrom
feature/php-86

Conversation

@oliverklee

Copy link
Copy Markdown
Collaborator

No description provided.

@coveralls

coveralls commented Aug 22, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 75.873%. remained the same — feature/php-86 into main

@oliverklee
oliverklee marked this pull request as draft August 22, 2026 10:41
@oliverklee

Copy link
Copy Markdown
Collaborator Author

This probably requires the PHPStan update in #1610.

@oliverklee
oliverklee force-pushed the feature/php-86 branch 2 times, most recently from 2b5a6dd to 82e2fb2 Compare August 28, 2026 15:35
@JakeQZ

JakeQZ commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

This probably requires the PHPStan update in #1610.

That's now resolved.

Seems we're both trying to rebase this at the same time. Hope I haven't trampled on your branch.

The unit tests are still failing with PHP 8.6...

@JakeQZ

JakeQZ commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

The unit tests are still failing with PHP 8.6...

The error is from https://github.com/enojaroff/HOA-Consistency/blob/master/Source/Prelude.php#L54, in a dependency of PHPStan that appears to be no longer maintained.

I don't know how soon it is likely to be fixed and then make its way into PHPStan, if ever. I've logged phpstan/phpstan#15127.

If we want to move forward with PHP 8.6 sooner, we could temporarily put a try...catch block in the test. Though I don't know what it should be catching, and don't have any plans to install PHP 8.6 locally to find out. The test would still run as intended on PHP<=8.5.

@JakeQZ

JakeQZ commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

#1627 should help, following review, and then rebase of this.

@oliverklee
oliverklee marked this pull request as ready for review August 29, 2026 14:29
@oliverklee
oliverklee requested a review from JakeQZ August 29, 2026 14:30
@JakeQZ
JakeQZ merged commit 0d62e3b into main Aug 29, 2026
26 checks passed
@JakeQZ
JakeQZ deleted the feature/php-86 branch August 29, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants