fix(rust-supply-chain): install toolchain before cargo audit/machete - #114
Merged
Merged
Conversation
The audit and machete jobs invoked 'cargo <tool>' with no Rust toolchain setup: the 'toolchain' input existed but was never consumed. The jobs passed only where a toolchain was ambient on the runner image (ubuntu-latest, some self-hosted slots) and failed with 'cargo: command not found' where it was not. Install actions-rust-lang/setup-rust- toolchain in both jobs using the declared input; caller interface is unchanged. Signed-off-by: rldyourmnd <danil@nddev.it.com>
This was referenced Sep 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
auditandmachetejobs inrust-supply-chain.ymlrancargo <tool>with no Rust toolchain setup: thetoolchaininput (defaultstable) existed but was never consumed by a step. The jobs passed only where a toolchain happened to be ambient on the runner image —ubuntu-latestand some self-hosted slots — and failed withcargo: command not foundwhere it was not (observed:nddev-linuxrunner slotgha-runner-2, NDDev-it-com/setup-systems#320, two consecutive runs).Both jobs now install
actions-rust-lang/setup-rust-toolchainwith the declaredtoolchaininput beforetaiki-e/install-action. Caller interface unchanged;denyis untouched (Docker action, no cargo needed).Type of change
Threat-model note
The new step runs
actions-rust-lang/setup-rust-toolchain@166cdcfd(v1.17.0), already registered incatalog/tools.ymland used by five workflows in this tree (rust-ci,benchmark,benchmark-compare,fuzzing,mutation-testing). It installs a rustup toolchain under the caller-declaredtoolchaininput — aworkflow_callinput, so it is fixed by the caller's pinned commit, not attacker-controlled. No new egress endpoint, token scope, or secret exposure;used_byupdated accordingly.Permissions diff
No change.
auditandmachetekeepcontents: read; the added step needs none.Checklist
validate_all.pycore: OK; touched: OK (change committed after scoping; the capability declares no expiring product facts)actionlintclean on the edited workflowzizmor@1.26.1 --persona pedantic --min-severity lowwith GH_TOKEN: no findingscatalog/tools.ymlused_byupdated;generate_docs.pyproduced no driftCHANGELOG.mdentry under[Unreleased]validate_all.pyshowsproduct-facts-calendarFAIL on three expired facts (circleci-free, circleci-open-source, harness-free — expired 2026-09-17/18) — pre-existing scheduled-tier expiry, unrelated to this change