fix(reusable): name this repository when using its vendored actions - #122
Merged
Merged
Conversation
`./actions/...` in a called workflow resolves against the caller's workspace, never against the repository that holds the workflow. Five `uses:` were written that way while vendoring, and each fails at job setup for every cross-repository caller. ci-feedback.yml has used `./actions/ci-feedback` since 0.1.21. It runs no checkout, so the workspace is empty and the step cannot resolve. Its job only fires on a failed conclusion, which is why three releases shipped with the CI-feedback path silently unable to publish: github-device-sync run 35541640707 finally exercised it and reported `Can't find 'action.yml' ... under /home/runner/work/github-device-sync/github-device-sync/actions/ci-feedback`. private-security-bundle-free.yml gained four `./actions/tool-cache` references in 0.1.22/0.1.23, replacing a fully-qualified archived-repository pin that worked. This workflow does check out the caller, so the path resolved into the caller's tree: setup-systems run 35541466805 failed with `Can't find 'action.yml' ... under .../setup-systems/setup-systems/actions/tool-cache`. All five now name the repository and pin it at 96215b3 (0.1.23), the commit where both vendored actions already live. catalog/cache-contract.yml declares the producer under the same string, which is what cache-contract compares. Vendoring the actions was right; addressing them with `./` was not. A called workflow has no path to its own repository unless it names it. Signed-off-by: rldyourmnd <danil@nddev.it.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 20, 2026
Closed
This was referenced Sep 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./actions/...in a called workflow resolves against the caller's workspace, never against the repository that holds the workflow. Fiveuses:were written that way while vendoring, and every one of them fails at job setup for a cross-repository caller.Two live failures, both observed today
ci-feedback.yml—./actions/ci-feedbacksince 0.1.21. The job runs no checkout, so the workspace is empty. Itsif:only fires on a failed conclusion, which is why three releases shipped with the CI-feedback path silently unable to publish anything. It was finally exercised ingithub-device-syncrun 35541640707:private-security-bundle-free.yml— four./actions/tool-cachereferences added in 0.1.22/0.1.23, replacingNDDev-Archive/github-actions-garm/actions/tool-cache@468af475, which was fully qualified and worked. This workflow does check out the caller, so the relative path resolved into the caller's tree.NDDev-it-com/setup-systemsrun 35541466805:Fix
All five now name the repository and pin it:
NDDev-OpenNetwork/ci-workflows/actions/<name>@96215b32. That commit is 0.1.23, where both vendored actions already live, so the pin is real and immutable rather than a forward reference.catalog/cache-contract.ymldeclares the producer under the same string —cache-contractcompares theuses:text exactly, and caught the mismatch when only the workflow was changed.Vendoring the actions was right. Addressing them with
./was not: a called workflow has no path to its own repository unless it names it.Verification
validate_all.py --tier core— RC=0, 47 validators OK, zero failures, includingcache-contract,pinned-actions,actionlint-contractandrunner-routing.Consumer impact
The estate-wide convergence onto 0.1.23 is held for this. The four private callers of
private-security-bundle-free.yml(setup-systems,nddev-platform-backend,nddev-seo-service,nddev-observability-service) cannot pass on 0.1.23; every reusable caller ofci-feedback.ymlis affected too. Consumers will be pointed at the release carrying this fix instead.🤖 Generated with Claude Code