fix(bootstrap): keep hardening flags set -e safe - #168
Merged
Merged
Conversation
A desktop-server or server descriptor without ssh/ufw/fail2ban made append_hardening_flags return 1 as the last command of the profile case, so the orchestrator exited before phase 0. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
append_hardening_flagsusedcmd && appendas the last statement of thedesktop-server/servercase arms.set -ethat exits 1 when hardening is unset, so--phase 1 --applynever builtgds.iftests; cover desktop-server--docker-mode rootfulwith no hardening.Test plan
pytest tests/test_bootstrap_device.pyMade with Cursor