Skip to content

feat: add orphan record identification and removal - #150

Merged
stevenhsd merged 1 commit into
release_v010from
fix/gr-ndit-1881-implement_group_and_orphan_rejections
Sep 11, 2026
Merged

stevenhsd merged 1 commit into
release_v010from
fix/gr-ndit-1881-implement_group_and_orphan_rejections

feat: add orphan record identification and removal

d55a63f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Sep 9, 2026 in 33s

Annotations

Check warning on line 343 in src/dve/core_engine/backends/implementations/spark/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCGn1sKBhbJwc6lBSmG&open=AaCGn1sKBhbJwc6lBSmG&pullRequest=150

Check warning on line 423 in src/dve/core_engine/backends/base/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "list(...)[0]" with "next(iter(...))" to avoid materializing the entire iterable.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCGn11OBhbJwc6lBSmK&open=AaCGn11OBhbJwc6lBSmK&pullRequest=150

Check failure on line 379 in src/dve/core_engine/backends/base/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCGn11OBhbJwc6lBSmI&open=AaCGn11OBhbJwc6lBSmI&pullRequest=150

Check warning on line 384 in src/dve/core_engine/backends/implementations/spark/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCGn1sKBhbJwc6lBSmH&open=AaCGn1sKBhbJwc6lBSmH&pullRequest=150

Check warning on line 414 in src/dve/core_engine/backends/base/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "list(...)[0]" with "next(iter(...))" to avoid materializing the entire iterable.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCGn11OBhbJwc6lBSmJ&open=AaCGn11OBhbJwc6lBSmJ&pullRequest=150