feat: group rejections for mandatory primary keys - #152

Open

georgeRobertson wants to merge 1 commit into

release_v010from

feature/gr-ndsp-619-add_group_level_rejections

SonarQubeCloud / SonarCloud Code Analysis succeeded Sep 11, 2026 in 39s

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 635 in src/dve/pipeline/pipeline.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCR85mcrjlCx3CsssSS&open=AaCR85mcrjlCx3CsssSS&pullRequest=152

Check warning on line 517 in src/dve/core_engine/backends/base/rules.py

sonarqubecloud / SonarCloud Code Analysis

Replace "list(...)[0]" with "next(iter(...))" to avoid materializing the entire iterable.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCR85kzrjlCx3CsssSO&open=AaCR85kzrjlCx3CsssSO&pullRequest=152

Check failure on line 415 in src/dve/core_engine/backends/base/rules.py

sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal " AND " 3 times.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCR85kzrjlCx3CsssSL&open=AaCR85kzrjlCx3CsssSL&pullRequest=152

Check failure on line 483 in src/dve/core_engine/backends/base/rules.py

sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCR85kzrjlCx3CsssSN&open=AaCR85kzrjlCx3CsssSN&pullRequest=152

Check warning on line 391 in src/dve/core_engine/backends/implementations/spark/rules.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCR85jnrjlCx3CsssSK&open=AaCR85jnrjlCx3CsssSK&pullRequest=152

Check warning on line 634 in src/dve/pipeline/pipeline.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCR85mcrjlCx3CsssSR&open=AaCR85mcrjlCx3CsssSR&pullRequest=152

Check failure on line 388 in src/dve/core_engine/backends/base/rules.py

sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCR85kzrjlCx3CsssSM&open=AaCR85kzrjlCx3CsssSM&pullRequest=152

Check warning on line 632 in src/dve/pipeline/pipeline.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCR85mcrjlCx3CsssSP&open=AaCR85mcrjlCx3CsssSP&pullRequest=152

Check warning on line 633 in src/dve/pipeline/pipeline.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaCR85mcrjlCx3CsssSQ&open=AaCR85mcrjlCx3CsssSQ&pullRequest=152

View more details on SonarQubeCloud