Skip to content

NIAD-3496: adding more RCMR_IN030000UK07-related skeleton processing tests #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ORybak5 merged 2 commits into from
Sep 9, 2026
Merged

NIAD-3496: adding more RCMR_IN030000UK07-related skeleton processing tests #1334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0e1755
adding more RCMR_IN030000UK07-related skeleton processing tests
ORybak5 Sep 9, 2026
7f20603
RCMR_IN030000UK07-related skeleton processing test fix
ORybak5 Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .../src/test/java/uk/nhs/adaptors/pss/translator/service/SkeletonProcessingServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,33 @@ void When_IsEntireRcmrSkeletonCalledWithNonRcmrPayload_Expect_ReturnsFalse() thr
assertFalse((Boolean) method.invoke(skeletonProcessingService, "<MCCI_IN010000UK13>"));
}

@Test
void When_IsEntireRcmrSkeletonCalledWithUk07Payload_Expect_ReturnsTrue() throws Exception {
var method = SkeletonProcessingService.class.getDeclaredMethod("isEntireRcmrSkeleton", String.class);
method.setAccessible(true);

assertTrue((Boolean) method.invoke(skeletonProcessingService, "<RCMR_IN030000UK07>"));
}

@Test
void When_SkeletonAsWholeUk07Message_Expect_InboundMessagePayloadIsNewRCMRMessage()
throws TransformerException, SAXException {
var inboundMessage = new InboundMessage();
var attachmentLog = createSkeletonPatientAttachmentLog();
var skeletonMessage = "<RCMR_IN030000UK07>" + readInboundMessagePayloadFromFile();

inboundMessage.setPayload(readInboundMessagePayloadFromFile());
inboundMessage.setEbXML(readInboundMessageEbXmlFromFile());

when(attachmentHandlerService.getAttachment(any(), any())).thenReturn(skeletonMessage.getBytes(StandardCharsets.UTF_8));
when(xmlParseUtilService.getStringFromDocument(any())).thenReturn(skeletonMessage);

var newInboundMessage =
skeletonProcessingService.updateInboundMessageWithSkeleton(attachmentLog, inboundMessage, CONVERSATION_ID);

assertTrue(newInboundMessage.getPayload().contains("<RCMR_IN030000UK07"));
}

@Test
void When_NormalizeSkeletonXmlCalledWithXmlDeclaration_Expect_StripsDeclarationBeforeRcmrCheck() throws Exception {
var normalizeMethod = SkeletonProcessingService.class.getDeclaredMethod("normalizeSkeletonXml", String.class);
Expand Down
Loading