NPA-7488: Fix misalignment of misuse status reason

[ehallam]

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-7488

---

📄 Description/Summary of Changes

• Changed ROLE_DEACTIVATED_MISUSE_OF_SYSTEM to be ROLE_DEACTIVATED_SYSTEM_MISUSE

---

🧪 Developer Testing Carried Out

---

📋 PR Principles

• Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review.
• Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket.
• Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made.
• Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices.
• Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed.
• Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment.

🏷️ Naming Conventions Reminder

Please ensure the following naming conventions are followed:

• PR title follows the format: NPA-XXXX: <short-description>
• Branch name follows the convention: <type>/NPA-XXXX/<short-description>
• Commit messages follow the template: NPA-XXXX: <short-description>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

🔵 Needs a closer look

Bump the schema version to reflect the public contract change.

Pull request overview

Updates the OpenAPI contract to correct the misuse status-reason code and documentation.

Changes:

• Renames the enum value to ROLE_DEACTIVATED_SYSTEM_MISUSE.
• Updates its documented display mapping.

File summaries

File	Description
specification/validated-relationships-service-api.yaml	Corrects the status-reason enum and documentation.

Review details

Suppressed comments (1)

specification/validated-relationships-service-api.yaml:2498

• This changes the public StatusReasonCodeableConcept enum, but info.version remains 1.28.0. The repository's release guidance requires updating the schema version for a new schema contract; without that, published documentation and generated clients cannot distinguish this corrected enum from the previous contract. Please bump the specification version as part of this change.

                  - ROLE_DEACTIVATED_SYSTEM_MISUSE

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.