Skip to content

pyCHX upgrade with pixi - #91

Draft
Jennefer Maldonado (jennmald) wants to merge 15 commits into
NSLS2:mainfrom
jennmald:chx-upgrade
Draft

pyCHX upgrade with pixi#91
Jennefer Maldonado (jennmald) wants to merge 15 commits into
NSLS2:mainfrom
jennmald:chx-upgrade

Conversation

@jennmald

@jennmald Jennefer Maldonado (jennmald) commented Apr 14, 2026

Copy link
Copy Markdown

Goal of this PR was to update PyCHX to have proper linting applied and move to using pixi as a package manager.
This was originally started in the effort to make the streamlined procedure at the request of JGoodrichBNL and Andrei for releases to keep this package up to date.

@JGoodrichBNL

Copy link
Copy Markdown
Contributor

I'm spending some time this shutdown trying to do some work on pyCHX and came across this. This generally looks helpful, but I'm wondering if we could figure out if this collides with any of the work Xiaogang Yang (@XYangXRay) did recently. Perhaps a short meeting would be helpful? CCing Padraic Shafer (@padraic-shafer)

@padraic-shafer

Copy link
Copy Markdown
Contributor

There are a lot of changes in this PR. Without any PR description, it's difficult to guess what approach or strategy you were applying.

Jennefer Maldonado (@jennmald) If this PR is still applicable, could you provide some guidance about the various categories of changes? For example, were many of the files changed automatically by applying linter fixes?

@JGoodrichBNL

Copy link
Copy Markdown
Contributor

My question is does this PR conflict with the work Xiaogang Yang (@XYangXRay) did in PRs 93-97?

@jennmald

Copy link
Copy Markdown
Author

it looks like most of those PRs are empty for deployment purposes so I would guess no, but Xiaogang can confirm better than myself.

@padraic-shafer

Copy link
Copy Markdown
Contributor

Indeed, #94-97 were intentionally empty commits...intended just to test the firing of GH webhooks.

#94-97 have no effect on the pyCHX code, and no effect on the repo infrastructure.

@padraic-shafer

Copy link
Copy Markdown
Contributor

#93 was cancelled (closed without merging it) because it was not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants