fix(vllm): load Super-Omni RADIO final LayerNorm - #4036
Open
DanialTaheri wants to merge 2 commits into
Open
Conversation
Signed-off-by: Seyed Taheri <smohsenitahe@aws-cmh-slurm-1-vscode-01.cm.cluster>
Contributor
Author
|
/ok to test 194f391 |
Signed-off-by: Seyed Taheri <smohsenitahe@aws-cmh-slurm-1-vscode-01.cm.cluster>
Contributor
Author
|
/ok to test 4500a7a |
Contributor
Author
|
CI follow-up for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Aligns vLLM's Nemotron Super-Omni RADIO feature path with Megatron/HF by adding the checkpoint-backed final LayerNorm that is missing from vLLM 0.25.1.
The pinned vLLM implementation omitted the LayerNorm module, its forward application, and checkpoint/refit name mapping. With NeMo-RL's dummy startup load followed by refit, the missing module and mapping prevent the learned affine parameters from reaching the rollout model, causing visual features—and therefore rollout token log probabilities—to diverge from the Megatron policy.
This change:
vision_final_layernorm.*andvision_projector.vision_final_layernorm.*checkpoint names.default_weight_loader.Issues
None.
Usage
No new recipe option is required. The patch is selected from the model configuration and applied automatically during vLLM worker initialization. Successful activation emits:
Before your PR is "Ready for review"
Pre checks:
Additional Information
Target branch:
super-v3.5-posttraining.Focused test command: