Skip to content

build: enable multi-node HybridEP in container images - #4038

Open
seonjinn wants to merge 7 commits into
NVIDIA-NeMo:mainfrom
seonjinn:sna/hybridep-multinode-image-20260906
Open

build: enable multi-node HybridEP in container images#4038
seonjinn wants to merge 7 commits into
NVIDIA-NeMo:mainfrom
seonjinn:sna/hybridep-multinode-image-20260906

Conversation

@seonjinn

@seonjinn seonjinn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Build DeepEP with HYBRID_EP_MULTINODE=1 in both production Dockerfiles.
  • Include HYBRID_EP_MULTINODE in the uv seed compatibility key so stale single-node wheels are skipped without deleting reusable multi-node wheels.
  • Leave docker/install_apptainer.sh unchanged because it installs Apptainer and does not build DeepEP.

Why

DeepEP reads HYBRID_EP_MULTINODE while building its extension. Setting the variable only at runtime cannot add inter-node transport support to an existing single-node wheel.

This change also enables multi-node AutoModel HybridEP recipes proposed in #4037.

Testing

  • Docker HybridEP build configuration test: 1 passed.
  • ruff check
  • ruff format --check
  • docker buildx build --check for docker/Dockerfile
  • docker buildx build --check for docker/Dockerfile.ngc_pytorch
  • git diff --check

A full image build and multi-node runtime validation will be recorded separately.

Signed-off-by: seonjinn <sna@nvidia.com>
@seonjinn
seonjinn requested review from a team as code owners September 7, 2026 04:34
@copy-pr-bot

copy-pr-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@seonjinn seonjinn added the CI:L0 Run doctests and unit tests label Sep 7, 2026
@seonjinn

seonjinn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 116ac87

sharonyu-115
sharonyu-115 previously approved these changes Sep 7, 2026

@sharonyu-115 sharonyu-115 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Signed-off-by: seonjinn <sna@nvidia.com>
@seonjinn

seonjinn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test ff04168

Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
@seonjinn

seonjinn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 67f7159

1 similar comment
@seonjinn

seonjinn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 67f7159

@seonjinn
seonjinn requested a review from yuki-97 September 7, 2026 07:44
Signed-off-by: seonjinn <sna@nvidia.com>
@seonjinn

seonjinn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 8dde640

@seonjinn
seonjinn requested a review from terrykong September 8, 2026 00:55
Comment thread docker/Dockerfile
Comment thread docker/Dockerfile Outdated
Comment thread tests/unit/tools/test_docker_hybridep_build.py Outdated
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
@seonjinn

seonjinn commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 36275f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L0 Run doctests and unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants