-
Notifications
You must be signed in to change notification settings - Fork 587
Add ModelOpt agent plugin marketplace #2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "name": "modelopt", | ||
| "interface": { | ||
| "displayName": "NVIDIA Model Optimizer" | ||
| }, | ||
| "plugins": [ | ||
| { | ||
| "name": "modelopt", | ||
| "source": { | ||
| "source": "local", | ||
| "path": "./plugins/modelopt" | ||
| }, | ||
| "policy": { | ||
| "installation": "AVAILABLE", | ||
| "authentication": "ON_INSTALL" | ||
| }, | ||
| "category": "Productivity" | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../plugins/modelopt/skills | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This is not fully backward-compatible for repository-local users on Git-for-Windows checkouts with |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "$schema": "https://json.schemastore.org/claude-code-marketplace.json", | ||
| "name": "modelopt", | ||
| "version": "0.1.0", | ||
| "description": "Model Optimizer agent plugins.", | ||
| "owner": { | ||
| "name": "NVIDIA Corporation" | ||
| }, | ||
| "plugins": [ | ||
| { | ||
| "name": "modelopt", | ||
| "source": "./plugins/modelopt", | ||
| "description": "Skills for Model Optimizer development, quantization, deployment, and evaluation.", | ||
| "version": "0.1.0", | ||
| "author": { | ||
| "name": "NVIDIA Corporation" | ||
| }, | ||
| "category": "development" | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/benchmark-model-kernels |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ on: | |
| - "tools/mcp/**" | ||
| - "tools/resource_monitor.py" | ||
| - ".agents/skills/**" | ||
| - "plugins/modelopt/skills/**" | ||
|
chadvoegele marked this conversation as resolved.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The latest manifest-validation comment is still open. |
||
| schedule: | ||
| - cron: "0 0 * * *" # Nightly | ||
| workflow_dispatch: | ||
|
|
@@ -55,6 +56,7 @@ jobs: | |
| tools/mcp/** | ||
| tools/resource_monitor.py | ||
| .agents/skills/** | ||
| plugins/modelopt/skills/** | ||
|
chadvoegele marked this conversation as resolved.
|
||
| linux: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
|
|
@@ -190,7 +192,7 @@ jobs: | |
| # Override addopts to drop the repo's coverage/instafail plugins (not installed here). | ||
| run: | | ||
| pip install pytest | ||
| python -m pytest .agents/skills/ -o addopts="" -p no:cacheprovider -v | ||
| python -m pytest plugins/modelopt/skills/ -o addopts="" -p no:cacheprovider -v | ||
| unit-pr-required-check: | ||
| # Run even if some jobs are skipped | ||
| if: ${{ github.event_name == 'pull_request' && always() }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -170,7 +170,25 @@ Please read our [Contributing](./CONTRIBUTING.md) guidelines for details on how | |
|
|
||
| ## AI Agents | ||
|
|
||
| For AI-assisted development setup, see the [agent tooling notes](./.agents/TOOLING.md). | ||
| ModelOpt's agent skills can be installed from this repository and used in any | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The plugin is not currently usable from an arbitrary workspace as advertised. Only
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [agent comment] Addressed in b79d701. The nel-next and GDPVal helpers now ship under
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Installed marketplace copies only contain plugins/modelopt, but several bundled skills still execute checkout-relative paths such as .agents/skills/..., .agents/scripts/nel-next.sh, and scripts/deploy.sh; some required helpers are outside the plugin tree entirely. From a non-ModelOpt workspace these commands fail, contradicting this claim. Please package the required runtime helpers and resolve them relative to the installed skill/plugin, then add a smoke test from an unrelated working directory.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [agent comment] Addressed in b79d701. The nel-next and GDPVal helpers now ship under |
||
| workspace. | ||
|
|
||
| ### Claude Code | ||
|
|
||
| ```bash | ||
| claude plugin marketplace add https://github.com/NVIDIA/Model-Optimizer.git | ||
| claude plugin install modelopt@modelopt | ||
| ``` | ||
|
|
||
| ### Codex | ||
|
|
||
| ```bash | ||
| codex plugin marketplace add https://github.com/NVIDIA/Model-Optimizer.git | ||
| ``` | ||
|
|
||
| Then open `/plugins`, select the `modelopt` marketplace, and install `modelopt`. | ||
| Contributors can also use the skills directly from a checkout. See the | ||
| [agent tooling notes](./.agents/TOOLING.md). | ||
|
|
||
| ### Top Contributors | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| "$schema": "https://json.schemastore.org/claude-code-plugin-manifest.json", | ||
| "name": "modelopt", | ||
| "displayName": "ModelOpt", | ||
| "version": "0.1.0", | ||
| "description": "Skills for Model Optimizer development, quantization, deployment, and evaluation.", | ||
| "author": { | ||
| "name": "NVIDIA Corporation" | ||
| }, | ||
| "homepage": "https://github.com/NVIDIA/Model-Optimizer", | ||
| "repository": "https://github.com/NVIDIA/Model-Optimizer", | ||
| "license": "Apache-2.0", | ||
| "keywords": [ | ||
| "modelopt", | ||
| "quantization", | ||
| "evaluation", | ||
| "deployment", | ||
| "llm" | ||
| ], | ||
| "mcpServers": { | ||
| "modelopt": { | ||
| "command": "uvx", | ||
| "args": [ | ||
| "--from", | ||
| "git+https://github.com/NVIDIA/Model-Optimizer.git#subdirectory=tools/mcp", | ||
|
chadvoegele marked this conversation as resolved.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This existing supply-chain/reproducibility comment is unresolved in both this manifest and |
||
| "modelopt-mcp" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "name": "modelopt", | ||
| "version": "0.1.0", | ||
| "description": "Skills for Model Optimizer development, quantization, deployment, and evaluation.", | ||
| "author": { | ||
| "name": "NVIDIA Corporation", | ||
| "url": "https://github.com/NVIDIA/Model-Optimizer" | ||
| }, | ||
| "homepage": "https://github.com/NVIDIA/Model-Optimizer", | ||
| "repository": "https://github.com/NVIDIA/Model-Optimizer", | ||
| "license": "Apache-2.0", | ||
| "keywords": [ | ||
| "modelopt", | ||
| "quantization", | ||
| "evaluation", | ||
| "deployment", | ||
| "llm" | ||
| ], | ||
| "skills": "./skills/", | ||
| "mcpServers": "./.mcp.json", | ||
| "interface": { | ||
| "displayName": "ModelOpt", | ||
| "shortDescription": "Optimize, deploy, and evaluate models.", | ||
| "longDescription": "Provides Model Optimizer workflows for post-training quantization, deployment, evaluation, result comparison, and release validation.", | ||
| "developerName": "NVIDIA", | ||
| "category": "Developer Tools", | ||
| "capabilities": [ | ||
| "Interactive", | ||
| "Write" | ||
| ], | ||
| "defaultPrompt": [ | ||
| "Quantize this model with ModelOpt.", | ||
| "Deploy and evaluate this checkpoint.", | ||
| "Compare the baseline and quantized results." | ||
| ], | ||
| "brandColor": "#76B900" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "modelopt": { | ||
| "command": "uvx", | ||
| "args": [ | ||
| "--from", | ||
| "git+https://github.com/NVIDIA/Model-Optimizer.git#subdirectory=tools/mcp", | ||
| "modelopt-mcp" | ||
| ] | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| name: common | ||
| description: Shared ModelOpt support files. Use only when another ModelOpt skill directs you here. | ||
| --- | ||
|
|
||
| # Shared ModelOpt Support | ||
|
|
||
| This skill is a placeholder required for Codex plugin validation. | ||
|
|
||
| Read only the file named by the calling ModelOpt skill. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although writes through
.agents/skillsreach the new canonical tree on a symlink-capable checkout, the script still ends withgit diff $DEST_BASE/launching-evals $DEST_BASE/accessing-mlflow. Git pathspec traversal does not follow a tracked directory symlink, so this advertised review command now fails (or shows no canonical changes) after a sync. Please makeDEST_BASEand the final review pathsplugins/modelopt/skills, using.agents/skillsonly as the compatibility entry point.