feat(vm): run the supervisor outside the guest workload - #2945
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-2945.docs.buildwithfern.com/openshell |
4a8f295 to
532fa1b
Compare
532fa1b to
02e80eb
Compare
7e10ae3 to
02e80eb
Compare
02e80eb to
be91699
Compare
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
be91699 to
273655b
Compare
273655b to
f7c163d
Compare
0c5cd41 to
9291888
Compare
fd784d6 to
36d8ef7
Compare
Maintainer Convergence DecisionThanks @drew. I checked current head Root-cause findings:
Scope growth:
Reviewer-quality signals:
Maintainer action: decide whether supported VM stop/start must consume fresh Gator metadata
|
Maintainer Convergence DecisionThe bounded critical-only review of current head Root-cause findings:
Scope growth:
Reviewer-quality signals:
Maintainer action: decide whether supported VM stop/start must consume fresh Gator metadata
|
Maintainer Convergence DecisionThe current head Root-cause findings:
Scope growth:
Reviewer-quality signals:
Maintainer action: decide whether supported VM stop/start must consume fresh Gator metadata
|
Maintainer Convergence DecisionCurrent head Root-cause findings:
Scope growth:
Reviewer-quality signals:
Maintainer action: decide whether supported VM stop/start must consume fresh Gator metadata
|
Maintainer Convergence DecisionCurrent head Root-cause findings:
Scope growth:
Reviewer-quality signals:
Maintainer action: decide whether supported VM stop/start must consume fresh Gator metadata
|
PR Review StatusThanks @drew. I checked the two new VM generation commits on current head Blocking findings:
Carried findings:
Gator metadata
|
PR Review StatusThanks @drew. I checked the new restored-session rotation commit on current head Blocking findings:
Carried findings:
Gator metadata
|
PR Review StatusThanks @drew. I checked the new shared-path extraction on current head Blocking findings:
Carried findings:
Gator metadata
|
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
PR Review StatusThanks @drew. I checked the new session-lineage commit on current head Blocking findings:
Carried findings:
Gator metadata
|
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: the VM driver layer was reviewed incrementally against its current #2942 stacked base with the downstream RFC 0012 layers in view. The prior launch-contract findings were resolved, required testing completed, and the PR reached maintainer handoff before merge. I removed the active Gator metadata
|
Summary
Adopt the RFC 0012 split in the VM driver.
openshell-supervisorruns on the host, whileopenshell-sandboxruns as guest init and owns the agent process tree.The private guest channel uses the same pinned TLS server identity and launch-scoped sandbox JWT as every other driver, carried over vsock or the hypervisor Unix-socket mapping.
Related Issue
Part of #1737.
Changes
Testing
mise run pre-commitChecklist
Stack