Conversation
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 21, 2026 10:51
10 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-3504.docs.buildwithfern.com/openshell |
Closes #3502 Resolve trusted OCI runtime images with driver TOML, process environment, and compiled-default precedence across Docker, Podman, and Kubernetes. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
feat/3502-runtime-image-env-overrides/elezar
branch
from
September 21, 2026 12:05
d6b0148 to
b6b552e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add gateway-process overrides for the trusted sandbox-runtime and supervisor OCI images used by the built-in Docker, Podman, and Kubernetes drivers. The environment variables act as alternatives to the existing compiled defaults, so the normal configuration flow preserves
driver TOML > process environment > compiled default.Related Issue
Closes #3502
Changes
OPENSHELL_SANDBOX_RUNTIME_IMAGEandOPENSHELL_SUPERVISOR_IMAGEthe process-level defaults used consistently by Docker, Podman, and Kubernetes.gateway.envmechanism without generating operator TOML.Deviations from Plan
artifacts/packages/openshell.deband staged image/test artifacts. The Release Dev/Tag integration matrix builds and supplies those inputs for the existingubuntu-docker-rootful + deb + conformancelane.Testing
mise run pre-commitpasses (run with Nix-provided mise because the host PATH has no mise binary)Tests run:
cargo test -p openshell-core runtime_image_environment_value_replaces_compiled_default— 1 passedcargo test -p openshell-driver-docker sandbox_driver_config_rejects_trusted_runtime_image_overrides— 1 passedcargo test -p openshell-driver-podman -p openshell-driver-kubernetes sandbox_driver_config_rejects_trusted_runtime_image_overrides— 2 passedcargo check -p openshell-core -p openshell-gateway -p openshell-driver-docker -p openshell-driver-podman -p openshell-driver-kubernetes --all-targets— passedbash tasks/scripts/test-packaging-assets.sh— passed (Debian artifact staging skipped becausedpkg-debis unavailable on macOS)nix run .#tmachine -- test ubuntu-docker-rootful deb conformance— environment setup passed; installer stopped before exercising the change becauseartifacts/packages/openshell.debwas absentChecklist
Documentation updated: