[PyTorch] Avoid temporary state casts when loading FusedAdam checkpoints - #3507
Draft
bzantium wants to merge 1 commit into
Draft
[PyTorch] Avoid temporary state casts when loading FusedAdam checkpoints#3507bzantium wants to merge 1 commit into
bzantium wants to merge 1 commit into
Conversation
Signed-off-by: ryan.u <ryan.u@kakaocorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FusedAdam.load_state_dict()lets PyTorch cast parameter states to the parameter dtype before restoring them in the optimizer's configured dtypes. With BF16 parameters and FP32 moments, this creates temporary GPU allocations that are immediately discarded.Load parameter-group metadata and non-parameter state through PyTorch, then restore parameter states through the existing TE path. Keep the original path for subclasses and registered load hooks, which can observe intermediate state. Restored states continue to own their storage; checkpoint tensors are copied.
Type of change
Changes
Testing
All 23 targeted GPU tests pass. On the base revision, the allocation regression fails and the other 22 pass. Reloading initialized state for 4M BF16 parameters reduces extra peak allocation from 24 MiB to within the test's 1 MiB bound.
Validated on B200 with PyTorch 2.11 / CUDA 13.1, using the changed optimizer Python source with TE 2.14.1 backend libraries. A fresh current-main TE build has not been tested. Black, Pylint, and the repository license check pass.
Checklist: