Add cuDNN discovery and NCCL header support - #2680
Open
DEKHTIARJonathan wants to merge 1 commit into
Open
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends cuda_pathfinder’s component discovery catalog to cover cuDNN (shared libraries + headers) and NCCL headers, and wires those additions into the test/dependency setup used for validating wheel and conda layouts.
Changes:
- Add cuDNN dynamic-library descriptor metadata for Linux and Windows, plus a catalog test to validate expected wheel layout metadata.
- Add header descriptor metadata for cuDNN (Linux/Windows) and NCCL (Linux-only), plus a test to validate header metadata against expected wheel layouts.
- Update pathfinder conda test-environment helpers and
cuda_pathfindertest dependency groups to include cuDNN (and NCCL on Linux).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
toolshed/conda_create_for_pathfinder_testing.sh |
Add cudnn and nccl to the Linux conda-based test environment packages. |
toolshed/conda_create_for_pathfinder_testing.ps1 |
Add cudnn to the Windows conda-based test environment packages. |
cuda_pathfinder/tests/test_find_nvidia_headers.py |
Extend non-CTK distribution metadata patterns for cuDNN/NCCL and add a header descriptor layout test. |
cuda_pathfinder/tests/test_descriptor_catalog.py |
Add a descriptor-catalog test validating cuDNN wheel layout metadata. |
cuda_pathfinder/pyproject.toml |
Add nvidia-cudnn-cu12 / nvidia-cudnn-cu13 to the CUDA test dependency groups. |
cuda_pathfinder/cuda/pathfinder/_headers/header_descriptor_catalog.py |
Add header descriptor specs for cudnn and nccl. |
cuda_pathfinder/cuda/pathfinder/_dynamic_libs/descriptor_catalog.py |
Add a cuDNN dynamic-library descriptor spec for discovery on Linux/Windows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- cuDNN: added dynamic-library loading and header discovery. - NCCL: dynamic-library loading already existed; added the missing header discovery.
DEKHTIARJonathan
force-pushed
the
feature/cudnn-ncll
branch
from
August 21, 2026 05:20
19a6448 to
3d1eab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No linked issue; this change adds requested cuda-pathfinder support for cuDNN and NCCL.
Checklist