Skip to content

Add cuDNN discovery and NCCL header support - #2680

Open
DEKHTIARJonathan wants to merge 1 commit into
NVIDIA:mainfrom
DEKHTIARJonathan:feature/cudnn-ncll
Open

Add cuDNN discovery and NCCL header support#2680
DEKHTIARJonathan wants to merge 1 commit into
NVIDIA:mainfrom
DEKHTIARJonathan:feature/cudnn-ncll

Conversation

@DEKHTIARJonathan

Copy link
Copy Markdown

Description

No linked issue; this change adds requested cuda-pathfinder support for cuDNN and NCCL.

  • Add cuDNN 9 dynamic-library discovery for Linux x86_64/aarch64 and Windows x64.
  • Add cuDNN header discovery on Linux and Windows.
  • Add NCCL header discovery on Linux; NCCL dynamic-library and device-bitcode discovery already exist.
  • Add cuDNN CUDA 12/13 test dependencies and update the conda test-environment helpers.
  • Add catalog metadata tests and validate the supplied cuDNN, cuSPARSELt, and NCCL wheel layouts.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes (no public API additions).

Copilot AI lite review requested due to automatic review settings August 21, 2026 05:13
@copy-pr-bot

copy-pr-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the cuda.pathfinder Everything related to the cuda.pathfinder module label Aug 21, 2026
@DEKHTIARJonathan DEKHTIARJonathan self-assigned this Aug 21, 2026
@DEKHTIARJonathan DEKHTIARJonathan added this to the cuda.pathfinder next milestone Aug 21, 2026
@DEKHTIARJonathan
DEKHTIARJonathan requested a review from rwgk August 21, 2026 05:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request extends cuda_pathfinder’s component discovery catalog to cover cuDNN (shared libraries + headers) and NCCL headers, and wires those additions into the test/dependency setup used for validating wheel and conda layouts.

Changes:

  • Add cuDNN dynamic-library descriptor metadata for Linux and Windows, plus a catalog test to validate expected wheel layout metadata.
  • Add header descriptor metadata for cuDNN (Linux/Windows) and NCCL (Linux-only), plus a test to validate header metadata against expected wheel layouts.
  • Update pathfinder conda test-environment helpers and cuda_pathfinder test dependency groups to include cuDNN (and NCCL on Linux).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
toolshed/conda_create_for_pathfinder_testing.sh Add cudnn and nccl to the Linux conda-based test environment packages.
toolshed/conda_create_for_pathfinder_testing.ps1 Add cudnn to the Windows conda-based test environment packages.
cuda_pathfinder/tests/test_find_nvidia_headers.py Extend non-CTK distribution metadata patterns for cuDNN/NCCL and add a header descriptor layout test.
cuda_pathfinder/tests/test_descriptor_catalog.py Add a descriptor-catalog test validating cuDNN wheel layout metadata.
cuda_pathfinder/pyproject.toml Add nvidia-cudnn-cu12 / nvidia-cudnn-cu13 to the CUDA test dependency groups.
cuda_pathfinder/cuda/pathfinder/_headers/header_descriptor_catalog.py Add header descriptor specs for cudnn and nccl.
cuda_pathfinder/cuda/pathfinder/_dynamic_libs/descriptor_catalog.py Add a cuDNN dynamic-library descriptor spec for discovery on Linux/Windows.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@DEKHTIARJonathan DEKHTIARJonathan added the feature New feature or request label Aug 21, 2026
  - cuDNN: added dynamic-library loading and header discovery.
  - NCCL: dynamic-library loading already existed; added the missing header discovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.pathfinder Everything related to the cuda.pathfinder module feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants