Unconditionally stop early_cpufj if launched - #1846
Conversation
If early_cpufj was started, it should be stopped and joined regardless of whether presolve finished with a result or failed/timed out, matching the behavior of early_structural.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughChangesEarly CPUFJ cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Launched early CPUFJ work is now stopped and joined regardless of presolve outcome, preventing lifecycle cleanup from being skipped. No actionable merge-readiness risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
If early_cpufj was started, it should be stopped and joined regardless of whether presolve finished with a result or failed/timed out, matching the behavior of early_structural.
Full disclosure: done with the help of Gemini AI.
Description
Issue
Checklist