chore(ci): setup scene and plot - #212
Open
coryrylan wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
scope(ci)
scope(internals)
scope(cli)
scope(docs)
dependencies
📝 WalkthroughWalkthroughAdded initial ChangesPlot and Scene packages
Estimated code review effort: 4 (Complex) | ~45 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/internals/metadata/package.json`:
- Around line 117-121: Add the ../../plot:build task to the generate:api
dependency list in package.json, ensuring Plot’s custom-elements manifest is
built before API generation and Plot elements are included in static/api.json.
In `@projects/plot/NOTICE.md`:
- Line 1: Resolve MD041 for all affected Markdown files: in
projects/plot/NOTICE.md (line 1), change the plain NOTICE text to a top-level
heading or exclude intentional plain-text notices from linting; in
projects/scene/CHANGELOG.md (line 1), add a top-level Changelog heading before
the existing version heading; and in projects/scene/NOTICE.md (line 1), change
NOTICE to a top-level heading or exclude it from Markdown linting.
In `@projects/plot/package.json`:
- Line 8: Update the package metadata description field to a concise, accurate
description of the Plot element, such as “Plot element for NVIDIA Elements,” so
metadata consumers receive a non-empty value.
- Around line 309-333: Update the lint target dependencies so lint:style is
reachable, and add lint:style to the ci target dependencies alongside
lint:eslint. Preserve the existing lint:style command and file configuration.
- Around line 326-333: Update the lint:style configuration in package.json to
use ../../stylelint.config.mjs instead of ../../../stylelint.config.mjs in both
the stylelint command and the files array.
In `@projects/scene/package.json`:
- Around line 67-80: Add a lint:style script to the scripts section and update
the lint task configuration so lint depends on lint:style alongside the existing
lint:eslint task, ensuring CSS sources are checked in CI.
In `@projects/site/src/docs/plot/index.md`:
- Around line 1-7: Update the documentation sidebar in common.js to add links
for /docs/plot/ and /docs/scene/, and include both routes in the group’s
expanded/selected condition. The affected pages are
projects/site/src/docs/plot/index.md (lines 1-7) and
projects/site/src/docs/scene/index.md (lines 1-7); neither page requires a
direct change.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: ee5d83d4-b5cd-4704-9de5-a64b88e68073
⛔ Files ignored due to path filters (5)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlprojects/plot/.visual/plot.dark.pngis excluded by!**/*.pngprojects/plot/.visual/plot.pngis excluded by!**/*.pngprojects/scene/.visual/scene.dark.pngis excluded by!**/*.pngprojects/scene/.visual/scene.pngis excluded by!**/*.png
📒 Files selected for processing (72)
NOTICE.mdknip.config.jspackage.jsonpnpm-workspace.yamlprojects/cli/NOTICE.mdprojects/internals/metadata/package.jsonprojects/internals/metadata/src/tasks/api.utils.tsprojects/plot/.gitignoreprojects/plot/CHANGELOG.mdprojects/plot/DEVELOPMENT.mdprojects/plot/NOTICE.mdprojects/plot/README.mdprojects/plot/eslint.config.jsprojects/plot/package.jsonprojects/plot/src/declarations.d.tsprojects/plot/src/index.test.lighthouse.tsprojects/plot/src/index.test.tsprojects/plot/src/index.tsprojects/plot/src/plot/define.tsprojects/plot/src/plot/index.tsprojects/plot/src/plot/plot.cssprojects/plot/src/plot/plot.examples.tsprojects/plot/src/plot/plot.test.axe.tsprojects/plot/src/plot/plot.test.lighthouse.tsprojects/plot/src/plot/plot.test.ssr.tsprojects/plot/src/plot/plot.test.tsprojects/plot/src/plot/plot.test.visual.tsprojects/plot/src/plot/plot.tsprojects/plot/tsconfig.jsonprojects/plot/tsconfig.lib.jsonprojects/plot/vite.config.tsprojects/plot/vitest.axe.tsprojects/plot/vitest.config.tsprojects/plot/vitest.lighthouse.htmlprojects/plot/vitest.lighthouse.tsprojects/plot/vitest.ssr.tsprojects/plot/vitest.visual.htmlprojects/plot/vitest.visual.tsprojects/scene/.gitignoreprojects/scene/CHANGELOG.mdprojects/scene/DEVELOPMENT.mdprojects/scene/NOTICE.mdprojects/scene/README.mdprojects/scene/eslint.config.jsprojects/scene/package.jsonprojects/scene/src/declarations.d.tsprojects/scene/src/index.test.lighthouse.tsprojects/scene/src/index.test.tsprojects/scene/src/index.tsprojects/scene/src/scene/define.tsprojects/scene/src/scene/index.tsprojects/scene/src/scene/scene.cssprojects/scene/src/scene/scene.examples.tsprojects/scene/src/scene/scene.test.axe.tsprojects/scene/src/scene/scene.test.lighthouse.tsprojects/scene/src/scene/scene.test.ssr.tsprojects/scene/src/scene/scene.test.tsprojects/scene/src/scene/scene.test.visual.tsprojects/scene/src/scene/scene.tsprojects/scene/tsconfig.jsonprojects/scene/tsconfig.lib.jsonprojects/scene/vite.config.tsprojects/scene/vitest.axe.tsprojects/scene/vitest.config.tsprojects/scene/vitest.lighthouse.htmlprojects/scene/vitest.lighthouse.tsprojects/scene/vitest.ssr.tsprojects/scene/vitest.visual.htmlprojects/scene/vitest.visual.tsprojects/site/package.jsonprojects/site/src/docs/plot/index.mdprojects/site/src/docs/scene/index.md
coryrylan
force-pushed
the
topic-setup-projects
branch
from
August 12, 2026 00:27
c88b885 to
61e0f5c
Compare
Signed-off-by: Cory Rylan <crylan@nvidia.com>
coryrylan
force-pushed
the
topic-setup-projects
branch
from
August 12, 2026 00:31
61e0f5c to
dbc418e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/scene/package.json`:
- Line 8: Replace the empty description value in the package metadata with a
concise description of the Scene package, keeping the existing package metadata
unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: b040dd76-797c-49ef-9e5e-e892fc7cc678
📒 Files selected for processing (3)
projects/internals/metadata/package.jsonprojects/plot/package.jsonprojects/scene/package.json
| "release": { | ||
| "extends": "../../release.config.js" | ||
| }, | ||
| "description": "", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add a package description.
description is empty. The PR adds package metadata and site documentation. An empty value produces incomplete package metadata. Add a concise Scene package description.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@projects/scene/package.json` at line 8, Replace the empty description value
in the package metadata with a concise description of the Scene package, keeping
the existing package metadata unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
<nve-plot>and<nve-scene>.0.0.0packages with examples and custom-element registration.