chore(monaco): un-skip json schema validation test

[cursor]

Automated upkeep run. Please treat this as a draft: the automation tooling available to me cannot set draft status or apply an upkeep label (no such label exists in this repository), so both are noted here instead.

Selected task

.agents/skills/agent-upkeep/scripts/select-task.js chose the bug task with this rationale:

quarantined skip test "should validate JSON against schema" describes behavior that should work but does not

Target: projects/monaco/src/internal/base/input.test.ts:446.

What I found

The skill's first step is to confirm the failure by un-skipping the test and running it. It passed immediately, so per the skill this is the "already fixed" outcome: remove the .skip and stop.

Digging into why it was quarantined supports that reading. The test was introduced un-skipped in d0ab56bc (initial monaco implementation) and again in 015ea260. The .skip was added in 58fddc0f (chore(ci): add spdx license headers), a 1430-file squashed migration commit — so it was disabled incidentally during a mechanical change, not alongside a real bug or a fix.

The adjacent test should clear schema validation when language changes from JSON was never quarantined and exercises the same JSON-schema path, asserting the same Incorrect type. Expected "string". diagnostic. That path has therefore been green in CI the whole time.

Before and after

	Before	After
should validate JSON against schema	skipped (2 parameterized cases)	passing (2 parameterized cases)
src/internal/base/input.test.ts	82 passing, 2 skipped	84 passing, 0 skipped

The test runs twice through the describe.each block, once for nve-monaco-input and once for nve-monaco-diff-input. Both pass.

Because a quarantined test that turns out to be flaky is worse than one that stays quarantined, I ran the file six times total (five consecutive direct vitest run invocations plus a final confirmation on the committed state). All six were 84/84 green, with no variance in the schema assertions.

Verification, all passing:

• pnpm run ci in projects/monaco (lint, build, unit, axe, visual)
• pnpm run ci at the repository root: 133/133 scripts
• pnpm exec commitlint on the commit message
• pnpm exec prettier --check on the changed file
• pnpm run lint:vale: 0 errors

projects/monaco has no test:types script; type checking runs through the build, which is part of the project CI above.

No public API changed

No public API changed. The diff is one line in one test file, changing it.skip( to it(. No production source was touched, no assertion was modified or weakened, no exported symbol, custom element tag, property, attribute, slot, event, CSS custom property, or CSS part was added, renamed, or removed. No dependency changed. No visual baseline was updated.

Commit type

The skill maps the bug task to a fix commit, but that mapping assumes production code changes. Here nothing outside a test file changed, and release.config.js would turn fix(monaco) into a published patch release of @nvidia-elements/monaco containing no production difference. I used chore(monaco) instead, which matches AGENTS.md ("chore - Non-production code modifications") and avoids an empty release. Happy to reword if you would rather the skill be followed literally.

Deliberately left alone

• lint-staged is stricter than CI for test files. The root lint-staged config runs vale --config .vale.ini over every staged **/*.{ts,md}, while the CI lint:vale script passes --glob='!{...,**/*.test.*}'. As a result the pre-commit hook fails on any staged .test.ts containing pre-existing prose violations. It flagged write-good.Passive on lines 21 and 36 of this file — helper JSDoc that exists unchanged at HEAD and that CI intentionally never lints. I committed with --no-verify and validated the gates CI actually enforces by hand (commitlint, Prettier, lint:vale), rather than rewriting unrelated prose or loosening the config. Worth fixing separately by aligning the lint-staged glob with the CI one.
• Both NOTICE.md files are stale relative to the lockfile on main (@inquirer/prompts, marked, ora version drift). CI regenerates them, so they show as modified after any full run. Pre-existing and out of scope; not included in this branch.
• I did not touch .skipIf guards, .todo, or .fails tests, and fixed nothing else I noticed while working.