install the published helm oci chart in e2e tests - #2775
Open
abrarshivani wants to merge 1 commit into
Open
Conversation
abrarshivani
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
August 21, 2026 02:18
tariq1890
reviewed
Aug 21, 2026
The e2e workflow already packages and pushes the chart as an OCI artifact and gates both test jobs on that job succeeding, but the tests then installed the chart directory straight from the checkout. CI never exercised the artifact we publish. Expose the chart reference and version as outputs of the publish workflow and hand them to the test scripts as HELM_CHART and HELM_CHART_VERSION. When HELM_CHART is empty the scripts fall back to the chart in the working tree, so running tests/local.sh by hand still tests local changes. The default has to stay empty rather than an absolute path: local.sh forwards the variable over ssh and the controller's PROJECT_DIR does not exist on the test instance. Both e2e jobs now run helm show chart before setting up holodeck, so a missing or unpropagated tag fails in seconds instead of after an instance has been provisioned. Co-authored-by: Tariq <tariq181290@gmail.com> Signed-off-by: Abrar Shivani <ashivani@nvidia.com>
abrarshivani
force-pushed
the
ci-helm-oci-chart-e2e
branch
from
August 21, 2026 05:01
a617eba to
5342e8d
Compare
tariq1890
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI publishes the Helm chart as an OCI artifact and both e2e jobs already depend on that job, but the e2e scripts installed the chart directory from the checkout. The published artifact was never actually tested.
The publish workflow now exposes the chart reference and version as outputs, and the e2e scripts install from them. When
HELM_CHARTis unset the scripts fall back to the chart in the working tree, sotests/local.shis unchanged.Closes NVIDIA/cloud-native-team#367
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
e2e needs AWS, so this was checked locally:
helm templateagainst a published tag renders anonymously, the three render assertions inend-to-end-nvidia-driver.shpass against both the published and the local chart, and actionlint reports no new findings on either workflow. The real check is this PR's e2e run.