Honor RMDisableNoncontigAlloc in the PMA vidmem path - #1305
Open
matte-schwartz wants to merge 1 commit into
Open
Honor RMDisableNoncontigAlloc in the PMA vidmem path#1305matte-schwartz wants to merge 1 commit into
matte-schwartz wants to merge 1 commit into
Conversation
The RMDisableNoncontigAlloc registry key clears bAllowNoncontiguousAllocation, but the flag is only consulted by vidmemAllocResources() and heapAlloc() on the legacy heap path. _vidmemPmaAllocate() decides contiguity from the client's PHYSICALITY attribute alone and silently retries a failed contiguous allocation as noncontiguous, so the key has no effect on PMA-managed framebuffer heaps, which covers every modern GPU. Consult the flag in the PMA path as well. When noncontiguous allocation is disabled, allocate contiguously regardless of the requested physicality and skip the noncontiguous retry, so the allocation fails cleanly instead of silently degrading.
|
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RMDisableNoncontigAlloc registry key clears
bAllowNoncontiguousAllocation, but the flag is only consulted by vidmemAllocResources() and heapAlloc() on the legacy heap path. _vidmemPmaAllocate() decides contiguity from the client's PHYSICALITY attribute alone and silently retries a failed contiguous allocation as noncontiguous, so the key has no effect on PMA-managed framebuffer heaps, which covers every modern GPU.
Consult the flag in the PMA path as well. When noncontiguous allocation is disabled, allocate contiguously regardless of the requested physicality and skip the noncontiguous retry, so the allocation fails cleanly instead of silently degrading.