Minor ghp updates - #554
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated GHP system prompt currently instructs returning an “empty JSON object,” which conflicts with the enforced schema requiring an outputs key and can cause schema-validation failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR makes small post-collection updates for the GHP (geothermal heat pump) extraction flow, including prompt/scoping improvements and a minor model-cost registry addition.
Changes:
- Added a cost entry for the
gpt-5.6-luna-awsmodel. - Passed schema
$scopeinto one-shot structured extraction system-prompt formatting. - Refined the GHP extraction system prompt and heuristic keyword list.
File summaries
| File | Description |
|---|---|
compass/utilities/costs.py |
Adds pricing metadata for an additional model variant. |
compass/plugin/one_shot/components.py |
Threads schema $scope into system prompt formatting so prompts can reference it. |
compass/extraction/ghp/plugin_config.yaml |
Updates GHP extraction prompt wording and heuristic keyword negatives. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 66.61% 66.60% -0.01%
==========================================
Files 78 78
Lines 7707 7708 +1
Branches 779 779
==========================================
Hits 5134 5134
- Misses 2400 2401 +1
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Minor updates post GHP collection