Skip to content

Minor ghp updates - #554

Merged
ppinchuk merged 6 commits into
mainfrom
pp/minor_ghp_updates
Sep 8, 2026
Merged

Minor ghp updates#554
ppinchuk merged 6 commits into
mainfrom
pp/minor_ghp_updates

Conversation

@ppinchuk

@ppinchuk ppinchuk commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Minor updates post GHP collection

@ppinchuk ppinchuk self-assigned this Sep 4, 2026
@ppinchuk
ppinchuk requested a review from castelao as a code owner September 4, 2026 17:41
Copilot AI lite review requested due to automatic review settings September 4, 2026 17:41
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-llm Issues/pull requests related to LLMs labels Sep 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated GHP system prompt currently instructs returning an “empty JSON object,” which conflicts with the enforced schema requiring an outputs key and can cause schema-validation failures.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR makes small post-collection updates for the GHP (geothermal heat pump) extraction flow, including prompt/scoping improvements and a minor model-cost registry addition.

Changes:

  • Added a cost entry for the gpt-5.6-luna-aws model.
  • Passed schema $scope into one-shot structured extraction system-prompt formatting.
  • Refined the GHP extraction system prompt and heuristic keyword list.
File summaries
File Description
compass/utilities/costs.py Adds pricing metadata for an additional model variant.
compass/plugin/one_shot/components.py Threads schema $scope into system prompt formatting so prompts can reference it.
compass/extraction/ghp/plugin_config.yaml Updates GHP extraction prompt wording and heuristic keyword negatives.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread compass/extraction/ghp/plugin_config.yaml Outdated
@codecov-commenter

codecov-commenter commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.60%. Comparing base (a984ffa) to head (4884048).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
compass/plugin/one_shot/components.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   66.61%   66.60%   -0.01%     
==========================================
  Files          78       78              
  Lines        7707     7708       +1     
  Branches      779      779              
==========================================
  Hits         5134     5134              
- Misses       2400     2401       +1     
  Partials      173      173              
Flag Coverage Δ
unittests 66.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk
ppinchuk merged commit fd3df27 into main Sep 8, 2026
23 checks passed
@ppinchuk
ppinchuk deleted the pp/minor_ghp_updates branch September 8, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-llm Issues/pull requests related to LLMs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants