Add Edge Component showcase screens and re-enable form demos - #14
Open
lessevv wants to merge 4 commits into
Open
Add Edge Component showcase screens and re-enable form demos#14lessevv wants to merge 4 commits into
lessevv wants to merge 4 commits into
Conversation
…d side nav Adds 9 screens under app/NativeComponents/EdgeComponents demonstrating every Edge Component prop variant (display modes, scroll behavior, search fields, destructive actions, a logo title slot, a search tab item, and a header background image), listed in the demo launcher's own "Edge Components" group and registered under /edge-components/*. Repeated placeholder markup is factored into a shared partial (native.partials.edge-component-note) instead of being copy-pasted across files. Each screen is covered by a dedicated feature test asserting the actual rendered props, not just that it mounts without error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The docs' own hand-rolled examples for top-bar and bottom-nav already demonstrate a @tap-bound search action, a URL-bound settings action, and label-visibility on the bottom nav — none of which the reference screens rendered, so regenerating docs screenshots from them would have silently dropped those illustrations. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
It was plain unstyled text, unlike every other demo screen's caption copy, and stood out for the wrong reason in a docs screenshot. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Hide the side-nav reference screen's own nav bar so the drawer's ☰ affordance is the only leading icon on screen, and swap its drawer rows to plain list items for a cleaner docs screenshot. Re-enable the previously-disabled checkbox/toggle/select/radio-group sections in ExploreForms using the real <native:checkbox>, <native:toggle>, <native:select>, and <native:radio-group> components instead of the old hand-rolled pressable/icon fakes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lessevv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/edge-components/*reference screens (top bar, bottom nav, side nav + their prop variants) that mirror the exact code samples in the nativephp.com docs, so screenshots can never drift from what's documentedExploreForms, replacing the old hand-rolled pressable/icon fakes with the real<native:checkbox>,<native:toggle>,<native:select>, and<native:radio-group>componentsTest plan
php artisan test --filter="EdgeComponents|DemoScreensSmokeTest"passes (53 tests)🤖 Generated with Claude Code