Skip to content

fix(node-api): decode percent-encoded path before process.dlopen #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −6
Open

fix(node-api): decode percent-encoded path before process.dlopen #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/ios-node-api/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@ if (typeof interop === "undefined") {

const module = { exports: {} };

// `URL.pathname` is percent-encoded, but `process.dlopen` takes a filesystem path. Without
// decoding, a space in the path arrives as "%20" and the load fails with "no such file" —
// which happens for any app bundle whose path contains a space, e.g.
// /Applications/My App.app/… → /Applications/My%20App.app/…
// deno-lint-ignore no-process-globals
process.dlopen(module, new URL(path, metaURL).pathname);
process.dlopen(module, decodeURIComponent(new URL(path, metaURL).pathname));

module.exports.init(
// deno-lint-ignore no-process-globals
Expand Down
14 changes: 10 additions & 4 deletions packages/macos-node-api/index.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,18 @@ if (!isNativeScriptRuntime) {
// ===

const module = { exports: {} };
// `URL.pathname` is percent-encoded, but `process.dlopen` takes a filesystem path. Without
// decoding, a space in the path arrives as "%20" and the load fails with "no such file" —
// which happens for any app bundle whose path contains a space, e.g.
// /Applications/My App.app/… → /Applications/My%20App.app/…
process.dlopen(
module,
new URL(
"./build/RelWithDebInfo/NativeScript.apple.node/macos-arm64/NativeScript.framework/Versions/A/NativeScript",
`file://${__filename}`,
).pathname,
decodeURIComponent(
new URL(
"./build/RelWithDebInfo/NativeScript.apple.node/macos-arm64/NativeScript.framework/Versions/A/NativeScript",
`file://${__filename}`,
).pathname,
),
);
module.exports.init(process.env.METADATA_PATH);
} else if (typeof require !== "undefined") {
Expand Down
6 changes: 5 additions & 1 deletion packages/macos-node-api/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,12 @@ if (!isNativeScriptRuntime) {

const module = { exports: {} };

// `URL.pathname` is percent-encoded, but `process.dlopen` takes a filesystem path. Without
// decoding, a space in the path arrives as "%20" and the load fails with "no such file" —
// which happens for any app bundle whose path contains a space, e.g.
// /Applications/My App.app/… → /Applications/My%20App.app/…
// deno-lint-ignore no-process-globals
process.dlopen(module, new URL(path, metaURL).pathname);
process.dlopen(module, decodeURIComponent(new URL(path, metaURL).pathname));

module.exports.init(
// deno-lint-ignore no-process-globals
Expand Down
Loading