feat(review): know what has been sent, and correct a walkthrough - #25
Draft
fiddur wants to merge 3 commits into
Draft
feat(review): know what has been sent, and correct a walkthrough#25fiddur wants to merge 3 commits into
fiddur wants to merge 3 commits into
Conversation
Submitting a review left no trace on the findings that went. They stayed open, looking exactly like the ones held back, so the only way to learn what had already gone was to try sending again. A comment now carries the finding it came from, the result says which ones the forge took, and those are marked submitted - still open, because sending is not resolving. The dialog labels them and leaves them unselected, so resending is a deliberate act rather than an accident. A walkthrough could only be added to. An agent that recorded a wrong step had to add a second one and rely on the newest winning, leaving the bad one in the database - which happened here, and had to be cleaned out by hand. `agent tour-delete` removes one, or all of them for the session, and the review skill now says to check what it recorded and rebuild rather than stack. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
develop is the default branch and takes squash merges through pull requests only, matching the other repositories here. Nothing is merged into it locally, and the squashed commit rather than the branch is what gets offered upstream - head branches are deleted on merge. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
… the url gh resolves a fork's parent, so an unpinned `gh pr checkout 25` fetched whichever pull request carried that number upstream - it checked out nilbuild's feat/host branch and the diff came out as 5 files against an unrelated commit. `gh pr view` was pinned earlier; these two were missed. Found by comparing the rendered diff against the forge's own counts, which is the check that catches this class of thing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two gaps the first real submission exposed, plus a README that had fallen a long way behind.
Knowing what has been sent
Submitting left no trace on the findings that went out. They stayed
open, looking identical to theones held back, so the only way to learn what was already on the pull request was to try sending
again and read the "already existed" count.
createReviewreports back which ones the forge actually took — not every one offered, since duplicates and unpostable lines are filtered firstsubmitted_at. Deliberately its own column rather than a status: sending is not resolving, and a submitted finding is still open until someone deals with itCorrecting a walkthrough
A walkthrough could only be added to. An agent that recorded a wrong step had to add a second one and
rely on the newest winning, leaving the bad one in the database — which is exactly what happened
while reviewing #14378, and I had to remove it with SQL.
agent tour-delete [<id>]removes one, or all of them for the session, withDELETE /api/tours/:idfor symmetry with threads. The review skill now says to check what it recorded and rebuild rather
than stack.
README
It documented
[must-fix]/[suggestion]severities that are now configurable, said a PR opens"against its base branch" when it is now pinned to the base commit, and had nothing at all about
the reading order, the attention rules, the review composer, review state,
--repo, or the agentCLI. Five new sections, and the ones that were wrong are corrected.
Tests
threadToPayloadlegitimately gainedthreadId, so the test names it372 pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs