Custom InnerNetObjects by D1GQ · Pull Request #92 · NuclearPowered/Reactor

D1GQ · 2025-03-23T00:42:54Z

Introducing Custom InnerNetObjects

This PR introduces a set of improvements to make working with custom InnerNetObject easier, and more intuitive. The changes include:

Comprehensive XML Documentation:
- Added detailed documentation for key methods to improve code clarity and developer experience.
- Examples and usage instructions are provided to help developers quickly integrate custom InnerNetObject prefabs.
Utility Methods for Prefab Handling:
- Added methods like GetNetObjPrefab<T>, SpawnNewNetObject<T>, and SpawnNetObject to simplify the process of retrieving, instantiating, and spawning custom InnerNetObject prefabs.

Key Changes:

1. `GetNetObjPrefab<T>`

Purpose: Retrieves the prefab for a custom InnerNetObject of type T.

Usage:

var prefab = InnerNetObjectManager.GetNetObjPrefab<MyCustomObject>();

2. `SpawnNewNetObject<T>`

Purpose: Spawns a new InnerNetObject locally and on the network of type "T".

Usage:

var newObject = InnerNetObjectManager.SpawnNewNetObject<MyCustomObject>(ownerId: 1, spawnFlags: SpawnFlags.None);

3. `SpawnNetObject<T>` (Extension Method)

Purpose: Spawns an existing InnerNetObject instance on the network.

Usage:

var existingObject = new MyCustomObject();
existingObject.SpawnNetObject(ownerId: 1, spawnFlags: SpawnFlags.None);

Pietrodjaowjao · 2025-03-23T15:29:21Z

i just dont get the InnerNetObject attribute, it seems really unecessary since this can be done by checking subtypes in the assembly

Galster-dev · 2025-03-23T16:41:21Z

I think example class should be an actual simple example of what you can do with this instead of just a stub.

D1GQ · 2025-03-23T17:08:12Z

i just dont get the InnerNetObject attribute, it seems really unecessary since this can be done by checking subtypes in the assembly

The first reason is do to the issue with abstract monobehaviors and compiling it into il2cpp, second reason is I feel like it's more consistent using a attribute as the original class with Reactor, now I'm probably going to change the method of loading the prefab for it.

If y'all really want it to just be a custom subclass then I'll rework the logic.

Replaced InnerNetObjectAttribute with IgnoreInnerNetObjectAttribute, now automatically registers InnerNetObjects. Added more methods to load prefab.

D1GQ · 2025-03-23T18:11:38Z

i just dont get the InnerNetObject attribute, it seems really unecessary since this can be done by checking subtypes in the assembly

I've added some changes.

miniduikboot

Hey there, sorry for the lack of feedback. I've been busy and hoped other Reactor devs would've been active as well. I've read through the PR and made a few comments. I'm not fundamentally opposed to an API like this, but I think this has a few limitations that make it unsuitable for an environment where optional mods exist.

Let me know if you still want to push this PR forward

miniduikboot · 2025-06-02T21:48:34Z

+    /// This method searches through the AmongUsClient.Instance.NonAddressableSpawnableObjects array
+    /// to find a prefab of the specified type. If no matching prefab is found, an exception is thrown.
+    /// </remarks>
+    public static InnerNetObject? GetNetObjPrefab<T>() where T : InnerNetObject


Is it possible for this object id to desync between clients? For example, when multiple mods add objects, they may load in a different order, or a mod that is declared optional declares a net object as well (which shouldn't happen, but I think it is reasonable foreseable misuse)

In theory it shouldn't be possible because in IgnoreInnerNetObjectAttribute Register collects all the valid innernet object with prefabs then on IL2CPPChainloader.Finished everything is loaded in alphabetical order to try to prevent this problem, as long as everyone has the same mods everything should be synced up.

as long as everyone has the same mods

That isn't checked if the mod is not registered as RequiredOnAllSides. So either the API needs to be limited to these mods

miniduikboot · 2025-06-02T21:49:10Z

+namespace Reactor.Example;
+
+// The `IgnoreInnerNetObject` attribute is used to prevent this custom InnerNetObject
+// from being automatically registered by Reactor.


Should users of this API also declare this attribute?

Only to stop reactor automatically registering the innernet object

I don't get why you'd not want to register this net object. It's supposed to be an example of the API in use, would normal users want to use this attribute?

Aka, should this be the other way around: put an attribute for Reactor to register it? That would also interact better with mods that are already created

Co-authored-by: miniduikboot <mini@duikbo.at>

…etObjects

miniduikboot

Sorry for the delay, I keep forgetting about Reactor PR's. Let me know if you're still interesting in pursuing this

miniduikboot · 2026-09-04T19:15:26Z

+namespace Reactor.Example;
+
+// The `IgnoreInnerNetObject` attribute is used to prevent this custom InnerNetObject
+// from being automatically registered by Reactor.


I don't get why you'd not want to register this net object. It's supposed to be an example of the API in use, would normal users want to use this attribute?

Aka, should this be the other way around: put an attribute for Reactor to register it? That would also interact better with mods that are already created

miniduikboot · 2026-09-04T19:19:04Z

+    /// This method searches through the AmongUsClient.Instance.NonAddressableSpawnableObjects array
+    /// to find a prefab of the specified type. If no matching prefab is found, an exception is thrown.
+    /// </remarks>
+    public static InnerNetObject? GetNetObjPrefab<T>() where T : InnerNetObject


as long as everyone has the same mods

That isn't checked if the mod is not registered as RequiredOnAllSides. So either the API needs to be limited to these mods

miniduikboot · 2026-09-04T19:21:27Z

+        // Increase array length by one because of beginning if check in InnerNetClient.CoHandleSpawn()
+        var list2 = innerNetClient.SpawnableObjects.ToList();
+        list2.Add(new());
+        innerNetClient.SpawnableObjects = list2.ToArray();


Minor: This is converting the list to an array and back for each item. Can this be done at once for all InnerNetObjects?

D1GQ added 6 commits March 22, 2025 19:30

Add custom InnerNetObjects

304708a

clean up

dd9796e

add comments

335e88d

fix AmongUsClient.Instance being null by adding lateload

ca56992

Final Fix

962185f

Log if host

805cdbc

D1GQ added 2 commits March 23, 2025 13:06

Updated example.

f6be7b8

Replaced InnerNetObjectAttribute with IgnoreInnerNetObjectAttribute, now automatically registers InnerNetObjects. Added more methods to load prefab.

update info

0b12ae6

D1GQ and others added 8 commits March 23, 2025 15:43

Add Enum and EnumFlag argument support to MessageSerializer

de0145c

Handle each type individually

252e884

Remove Enum for MessageSerializer, is in another pr

51139e0

Load in alphabetical order

38a28af

Remove lateload. load in the same order no matter assembly order

50c8f84

oops

6f0732a

Merge branch 'NuclearPowered:master' into master

32d8ca3

Merge branch 'NuclearPowered:master' into master

232be5a

miniduikboot reviewed Jun 2, 2025

View reviewed changes

D1GQ and others added 4 commits July 9, 2025 20:41

Update Reactor/Networking/Attributes/IgnoreInnerNetObjectAttribute.cs

7e93c4e

Co-authored-by: miniduikboot <mini@duikbo.at>

Check for duplicates

0a3e33c

Merge branch 'master' of https://github.com/D1GQ/Reactor-CustomInnerN…

cc1c43e

…etObjects

Cleanup

7cdb078

miniduikboot requested changes Sep 4, 2026

View reviewed changes

Uh oh!

Conversation

D1GQ commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Introducing Custom InnerNetObjects

Key Changes:

1. GetNetObjPrefab<T>

2. SpawnNewNetObject<T>

3. SpawnNetObject<T> (Extension Method)

Uh oh!

Pietrodjaowjao commented Mar 23, 2025

Uh oh!

Galster-dev commented Mar 23, 2025

Uh oh!

D1GQ commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

D1GQ commented Mar 23, 2025

Uh oh!

miniduikboot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

D1GQ Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miniduikboot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

D1GQ commented Mar 23, 2025 •

edited

Loading

1. `GetNetObjPrefab<T>`

2. `SpawnNewNetObject<T>`

3. `SpawnNetObject<T>` (Extension Method)

D1GQ commented Mar 23, 2025 •

edited

Loading

D1GQ Jul 10, 2025 •

edited

Loading