-
Notifications
You must be signed in to change notification settings - Fork 101
Add work-in-progress new TopNav component #3267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rosslovas
wants to merge
1
commit into
main
Choose a base branch
from
ross/new-top-nav-wip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| --- | ||
| import Logo from '../assets/octopus-logo-v2.svg'; | ||
| import Button from './Button.astro'; | ||
|
|
||
| type Props = { | ||
| active?: string; | ||
| links?: { label: string; href: string }[]; | ||
| }; | ||
|
|
||
| // TODO: Make these real links | ||
| const { | ||
| active = 'Docs', | ||
| links = [ | ||
| { label: 'Docs', href: '#' }, | ||
| { label: 'Learn', href: '#' }, | ||
| { label: 'API', href: '#' }, | ||
| { label: 'CLI', href: '#' }, | ||
| ], | ||
| } = Astro.props; | ||
| --- | ||
|
|
||
| <header class="top-nav"> | ||
| <div class="top-nav__leading"> | ||
| <a | ||
| class="top-nav__logo" | ||
| href="https://octopus.com" | ||
| aria-label="Octopus Deploy" | ||
| > | ||
| <Logo class="top-nav__logo-mark" aria-hidden="true" /> | ||
| </a> | ||
| <nav class="top-nav__links" aria-label="Sections"> | ||
| { | ||
| links.map(({ label, href }) => ( | ||
| <a | ||
| class:list={[ | ||
| 'top-nav__link', | ||
| label === active && 'top-nav__link--active', | ||
| ]} | ||
| href={href} | ||
| aria-current={label === active ? 'page' : undefined} | ||
| > | ||
| {label} | ||
| </a> | ||
| )) | ||
| } | ||
| </nav> | ||
| </div> | ||
| <div class="top-nav__trailing"> | ||
| <!-- All of these are just non-functional and for visual/presentation only at this stage --> | ||
| <Button icon="fa-regular fa-moon" aria-label="Switch to dark theme" /> | ||
| <!-- TODO: Presumably at least some of these buttons should be <a> rather than <button> in practice, which isn't possible just yet --> | ||
| <Button label="Changelog" /> | ||
| <Button label="Sign in" /> | ||
| <Button label="Start for free" importance="loud" /> | ||
| </div> | ||
| </header> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected
fa-regular fa-moonto be the outline like their website says, but it's exactly the same as solid 🤔 Not sure why, but I'm just leaving this as a placeholder for now anyhow, as I'm just trying to get the layout right at this early stage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just had an icon, that wasn't on the free fontawesome fonts, i opted to just copy the svg from design-system-icons
https://www.octopus.design/latest/foundations/icons/system-icons-upsPwkne
it has a moon there too, I just opened up a new claude in octopusdeploy repo and got it to write the prompt for me and extract the code, you can do a better prompt but for berevity this prompt gave me the exact svg and the instructions to implement