fix(android): stop clipping the account row menu press circle OK-63780 - #122
Open
weatherstar wants to merge 2 commits into
Open
weatherstar wants to merge 2 commits into
weatherstar wants to merge 2 commits into
Conversation
The accountSelector DotHorOutline accessory keeps its 38dp press target by overhanging its 24dp layout slot with -7dp margins. The trailing column clips children and the row clips to padding by default, so the pressed circle rendered as a 24dp-wide pill on Android while iOS and desktop drew the full circle.
weatherstar
force-pushed
the
fix/native-list-account-menu-press-clip-ok-63780
branch
from
September 20, 2026 13:54
07b1e27 to
3c8839c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OK-63780.
On Android, pressing the account selector row's
...menu draws the pressed state as a 24dp-wide pill instead of the full 38dp circle. iOS and desktop draw the full circle.The accountSelector
DotHorOutlineaccessory keeps its 38dp press target by giving the icon a 38dp frame with -7dp start/end margins inside a 24dp layout slot (showTrailingIconinNativeListRowView.kt). The trailing column is aLinearLayoutwith the defaultclipChildren = true, andresetViews()puts the row back toclipToPadding = true, so the pressedroundedFill(..., 19f)is cut on both sides.Turn off
trailingColumn.clipChildrenand the row'sclipToPaddingin that accountSelector branch, and restoretrailingColumn.clipChildren = trueinresetViews()so recycled rows of other presentations keep their clipping. Row padding is 12dp, so the 7dp overhang still lies inside the row bounds.Validation:
...on a watch-only account row showed the clipped pill.dev-shell --shell local). Holding...now draws the full circle extending into the row's trailing padding, and releasing opens the account menu as before.git diff --checkpasses. Thenative-listAndroid unit tests cover pure Kotlin policy helpers only; this view-clipping change has no JVM test.Second commit bumps all 41 publishable packages to 3.0.152 with a CHANGELOG entry. The
example/react-nativeapps were not rebuilt in this repository. After release, app-monorepo needs a dependency upgrade to consume the fix.Refs OK-63780.