chore(example): scope setup caches and refresh each demo installation - #1985
Conversation
fadi-george
changed the title
| echo "Registering tarball with vp (refreshes bun.lock integrity hash)..." | ||
| vp remove react-native-onesignal 2>/dev/null || true | ||
| vp add file:../../react-native-onesignal.tgz | ||
| vp exec bun remove react-native-onesignal |
There was a problem hiding this comment.
Don't insert bun here. Use vp remove react-native-onesignal. vp exec for pack is fine.
There was a problem hiding this comment.
Addressed in the current branch. The setup now uses Vite+ directly: vp remove react-native-onesignal for removal and vp add for the packed tarball. No Bun command remains in this path. Bash syntax checks and the complete Vite+ suite (262 tests) pass.
|
Updated the setup to use Vite+ directly for both removal and addition. I also corrected the follow-up regression where vp install was being given a package argument; the tarball is now registered with vp add. Bash syntax and diff checks pass, and the Vite+ suite passes all 262 tests. |
…alidation Co-authored-by: Cursor <cursoragent@cursor.com>
|
I did some slight clean up to not use metro filestores and improved caching slightly. |
2 participants
Description
One Line Summary
Hash actual package/build inputs without generated Android output, support spaces, track per-demo installs separately from the shared tarball, and use commands supported by the pinned local Vite+ CLI. Scope Metro caches and process restarts to the selected demo.
Compatibility and observable changes
Example tooling only. Setup must run from one of the two supported demo directories. Other projects’ Metro caches and processes are no longer removed/stopped. Native dependency versions are unchanged.
Details
Motivation
The source audit reproduced the failure paths described below. This PR contains only the associated fix; unrelated audit changes are in separate PRs.
Scope
examples/setup.shexamples/demo/metro.config.jsexamples/demo-no-location/metro.config.js.gitignoreTesting
Five isolated shell-fixture reproductions fail on baseline and pass fixed: spaces, generated-output cache churn, stale second-demo installs, unrelated Metro cache deletion and omitted bundler configuration. Both real demo setup commands also succeed using the pinned toolchain.
Each code/tooling fix was also applied independently to upstream commit
a70312207cf094ac361eaa9196c317acb175c2cdand passed its targeted external actual-source diagnostics. Documentation snippets were checked separately. Native diagnostic harnesses use bridge/SDK doubles and are not an end-to-end push test.On the combined audit branch:
vp check: formatting, lint and type checks pass; native Spotless check passes.No checked-in test files were added or modified; regression evidence comes from external diagnostic harnesses and the existing suite. No physical-device, live notification delivery, Appium/BrowserStack, or release-workflow execution is claimed. The no-location example's stale native lock was updated locally to resolve the current SDK for verification; generated locks are not part of this PR.
Checklist