Skip to content

chore(example): clean icon-generation temporary files on failure #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadi-george merged 1 commit into from
Aug 28, 2026
Merged

chore(example): clean icon-generation temporary files on failure #1986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/generate-icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ try pngData.write(to: URL(fileURLWithPath: outputPath))

const tempDir = mkdtempSync(join(tmpdir(), 'onesignal-icon-'));
const swiftFile = join(tempDir, 'flatten.swift');
writeFileSync(swiftFile, swift);
try {
writeFileSync(swiftFile, swift);
execFileSync('swift', [swiftFile, src, dest], { stdio: 'ignore' });
} finally {
rmSync(tempDir, { recursive: true, force: true });
Expand Down Expand Up @@ -211,9 +211,9 @@ async function generateIos(): Promise<void> {
console.log('Generating iOS icons...');
const tempDir = mkdtempSync(join(tmpdir(), 'onesignal-ios-icon-'));
const iosSource = join(tempDir, 'ios-source-white.png');
await flattenToWhiteBackground(source, iosSource);
await writeIosContents();
try {
await flattenToWhiteBackground(source, iosSource);
await writeIosContents();
for (const { filename, pixels } of IOS_ICONS) {
await resize(iosSource, join(IOS_APPICONSET, filename), pixels);
console.log(` ${filename}: ${pixels}x${pixels}`);
Expand Down
Loading