docs: correct async getters and removable observer examples - #1987
Merged
fadi-george merged 2 commits intoSep 1, 2026
Merged
Conversation
The API table implied a single setter; document all four additive listeners. Co-authored-by: Cursor <cursoragent@cursor.com>
fadi-george
force-pushed
the
codex/onesignal-migration-examples
branch
from
September 1, 2026 00:26
a3607ba to
b9c64f7
Compare
fadi-george
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Use current asynchronous subscription getters, retain callback references for removal, fix the removeAliases syntax, and replace removed in-app-message handler APIs with addEventListener examples.
Compatibility and observable changes
Documentation only; no runtime behavior changes. The guide remains a v4-to-v5 migration reference rather than a promise of full latest-version API coverage.
Details
Motivation
The source audit reproduced the failure paths described below. This PR contains only the associated fix; unrelated audit changes are in separate PRs.
Scope
MIGRATION_GUIDE.mdTesting
Six extracted migration snippets type-check against current SDK declarations; the baseline has five missing-reference, syntax, or obsolete-method errors.
Each code/tooling fix was also applied independently to upstream commit
a70312207cf094ac361eaa9196c317acb175c2cdand passed its targeted external actual-source diagnostics. Documentation snippets were checked separately. Native diagnostic harnesses use bridge/SDK doubles and are not an end-to-end push test.On the combined audit branch:
vp check: formatting, lint and type checks pass; native Spotless check passes.No checked-in test files were added or modified; regression evidence comes from external diagnostic harnesses and the existing suite. No physical-device, live notification delivery, Appium/BrowserStack, or release-workflow execution is claimed. The no-location example's stale native lock was updated locally to resolve the current SDK for verification; generated locks are not part of this PR.
Checklist