Skip to content

Add list targets command and clarify target terminology - #2598

Merged
brondani merged 1 commit into
mainfrom
add-list-targets-command
Sep 7, 2026
Merged

Add list targets command and clarify target terminology#2598
brondani merged 1 commit into
mainfrom
add-list-targets-command

Conversation

@brondani

@brondani brondani commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Add list targets as the preferred command for listing <target-type>[@<target-set>] selections.
  • Retain list target-sets as a backward-compatible alias.
  • Update CLI help, API comments, and schema descriptions to distinguish targets from target sets.
  • Extend unit tests to cover the new command and legacy alias.

The terminology now reflects that selections may identify either a target type alone or a target type with a target set. Existing scripts using list target-sets remain supported.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Note: the global / copyright (pull_request) failure is unrelated to the changes in this PR. It was introduced earlier by a defect in PR #2587 and has already been reported in issue #2599.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Test Results

  2 files   -    41   14 suites   - 113   9m 40s ⏱️ - 9m 31s
482 tests  -   662  482 ✅  -   645  0 💤  - 17  0 ❌ ±0 
964 runs   - 1 463  964 ✅  - 1 405  0 💤  - 58  0 ❌ ±0 

Results for commit 923c54b. ± Comparison against base commit 66cb607.

This pull request removes 662 tests.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…

@brondani
brondani marked this pull request as ready for review September 7, 2026 13:57
@brondani
brondani requested a review from jkrech September 7, 2026 13:57
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.59%. Comparing base (66cb607) to head (923c54b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2598   +/-   ##
=======================================
  Coverage   72.58%   72.59%           
=======================================
  Files         185      185           
  Lines       30602    30603    +1     
  Branches    18009    18009           
=======================================
+ Hits        22213    22215    +2     
  Misses       6080     6080           
+ Partials     2309     2308    -1     
Flag Coverage Δ
projmgr-cov 87.97% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgr.h 100.00% <ø> (ø)
tools/projmgr/src/ProjMgr.cpp 86.57% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkrech jkrech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani
brondani merged commit d6847ba into main Sep 7, 2026
30 of 31 checks passed
@brondani
brondani deleted the add-list-targets-command branch September 7, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants