Skip to content

feat(rust-client): Add support for unsigned integer and more signed integer formats #24921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimonIT wants to merge 1 commit into
base: master
Choose a base branch
from
+38 −0
Open

feat(rust-client): Add support for unsigned integer and more signed integer formats #24921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...openapi-generator/src/main/java/org/openapitools/codegen/languages/RustClientCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,10 +696,22 @@ public String getSchemaType(Schema p) {
}
} else {
switch (p.getFormat()) {
case "int8":
return unsigned ? "u8" : "i8";
case "int16":
return unsigned ? "u16" : "i16";
case "int32":
return unsigned ? "u32" : "i32";
case "int64":
return unsigned ? "u64" : "i64";
case "uint8":
return "u8";
case "uint16":
return "u16";
case "uint32":
return "u32";
case "uint64":
return "u64";
}
}
}
Expand Down
26 changes: 26 additions & 0 deletions .../openapi-generator/src/test/java/org/openapitools/codegen/rust/RustClientCodegenTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,30 @@ public void testWithIntegerDefaults() {
s.setMinimum(BigDecimal.valueOf(0));
s.setMaximum(BigDecimal.valueOf(1));

s.setFormat("int8");
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Assert.assertEquals(codegen.getSchemaType(s), "i8");

s.setFormat("int16");
Assert.assertEquals(codegen.getSchemaType(s), "i16");

s.setFormat("int32");
Assert.assertEquals(codegen.getSchemaType(s), "i32");

s.setFormat("int64");
Assert.assertEquals(codegen.getSchemaType(s), "i64");

s.setFormat("uint8");
Assert.assertEquals(codegen.getSchemaType(s), "u8");

s.setFormat("uint16");
Assert.assertEquals(codegen.getSchemaType(s), "u16");

s.setFormat("uint32");
Assert.assertEquals(codegen.getSchemaType(s), "u32");

s.setFormat("uint64");
Assert.assertEquals(codegen.getSchemaType(s), "u64");

// Clear format - should use default of i32
s.setFormat(null);

Expand Down Expand Up @@ -181,6 +199,14 @@ public void testWithPreferUnsigned() {
s.setMaximum(BigDecimal.valueOf(Long.MAX_VALUE));
Assert.assertEquals(codegen.getSchemaType(s), "u32");

// Should respect hardcoded 8-bits, but prefer unsigned
s.setFormat("int8");
Assert.assertEquals(codegen.getSchemaType(s), "u8");

// Should respect hardcoded 16-bits, but prefer unsigned
s.setFormat("int16");
Assert.assertEquals(codegen.getSchemaType(s), "u16");

// Should respect hardcoded 32-bits, but prefer unsigned
s.setFormat("int32");
Assert.assertEquals(codegen.getSchemaType(s), "u32");
Expand Down
Loading