Skip to content

Support field names which aren't legal typescript identifiers. - #24967

Merged
wing328 merged 4 commits into
masterfrom
brendandburns-master
Sep 20, 2026
Merged

wing328 merged 4 commits into
masterfrom
brendandburns-master

Conversation

@wing328

@wing328 wing328 commented Sep 20, 2026

Copy link
Copy Markdown
Member

based on #24741 with updated samples

See:

kubernetes-client/javascript#2962


Summary by cubic

Generated TypeScript serializers now fall back to a field’s baseName when its JSON name is not a legal TypeScript identifier, instead of dropping the value.

  • An explicitly provided name value takes precedence when both names are present.
  • Updates generated samples and integration-test expectations; deserialization is unchanged.

Written for commit b3ffbf5. Summary will update on new commits.

Review in cubic

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

brendandburns and others added 4 commits August 19, 2026 21:41
- Add custom TLS server name support and update generated samples.\n- Fix the missing declaration.\n- Preserve unmapped baseName fields during TypeScript serialization.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@wing328 wing328 added this to the 7.26.0 milestone Sep 20, 2026
@wing328 wing328 changed the title Brendandburns master Support field names which aren't legal typescript identifiers. Sep 20, 2026
@wing328
wing328 marked this pull request as ready for review September 20, 2026 08:03
@wing328
wing328 merged commit 33a7df6 into master Sep 20, 2026
89 of 232 checks passed
@wing328
wing328 deleted the brendandburns-master branch September 20, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants